Repository navigation
Tests: kiri-init unit tests compile again after #371 - #396
Merged
Merged
Conversation
sguzman
added a commit
to sguzman/caskel
that referenced
this pull request
Nov 16, 2026
…fecycle fixes Adapt upstream commits 7846fe0 (libracoder#341), 231d230 (libracoder#371) and 5789abe (libracoder#396). Prerequisite process lifecycle handling supports safe exec and signal routing; seccomp profiles are compiled by the daemon and applied to start and exec. No WSL-only tests; Linux host regression suite follows separately. Depends on preceding Linux systemd restart cleanup on this feature branch.
sguzman
added a commit
to sguzman/caskel
that referenced
this pull request
Nov 16, 2026
…le fixes Selectively port upstream libracoder#341, libracoder#371, and libracoder#396 to Caskel's Linux agent. Includes prerequisites for safe signal/DNS lifecycle, Docker-style custom/default seccomp profiles, complete Linux unit tests (including privileged runner tests), runtime smoke tests, and reproducible Nix packaging. CI passing across Nix, CodeQL, UI, and Speed. Production Docker and current user services not touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Linux, the engine's unit tests (
cargo test -p kiri-init) didn't compile on main. This sets the one field that was missing.Motivation
#341 added a test-only
Process::for_testconstructor. #371 merged right after it and added aseccompfield toProcess. Each PR was fine on its own, but together the constructor no longer sets every field:CI doesn't build the Linux unit tests of
kiri-init, so it didn't catch this. The engine itself was not affected.Changes
crates/kiri-init/src/linux/container.rs:Process::for_testsetsseccomp: Vec::new(), which means the default filter, as for execs.Behaviour changes
None. Only test code changes.
Testing
cargo test -p kiri-initon Linux (WSL): compiles again, and 72 tests pass, including the two Engine: signals only reach running processes, and a failed start leaves no DNS name #341 added. 6 tests fail there on main too, because of that environment, and are unrelated.cargo clippy -p kiri-init --all-targets --target aarch64-unknown-linux-musl: no compile errors.Checklist