Repository navigation
Testcontainers' Mongo, and other exec-based containers, start on Kiri - #390
Merged
libracoder merged 2 commits intoNov 16, 2026
Merged
Conversation
luben93
force-pushed
the
exec-start-200-without-upgrade
branch
from
November 16, 2026 14:17
78311c1 to
9c0b257
Compare
Owner
|
@luben93 thanks for this PR. Before it can be reviewed and merged, every commit needs to be signed. GitHub shows these as unsigned: ffaaec1, 9c0b257. Please sign them (GPG or SSH, with the key added to your GitHub account as a signing key), then force-push. GitHub's guide: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
exec start and attach answered 101 to every client. Docker does that only for a request with an Upgrade header, and sends 200 OK with the raw stream as the body otherwise. docker-java (Testcontainers) sends none, and read no ExitCode from the exec. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
luben93
force-pushed
the
exec-start-200-without-upgrade
branch
from
November 16, 2026 17:36
9c0b257 to
e54b809
Compare
Contributor
Author
|
@libracoder both commits are signed now (SSH key added as a signing key) and show as Verified: 0247916 and e54b809. Could you take a look when you have time? Since the last push I also ran the patched build as a separate Kiri Dev instance on macOS (arm64, installed 0.2.1 guest kernel and disk):
Related: #126 makes the same change for attach. |
libracoder
pushed a commit
that referenced
this pull request
Nov 16, 2026
…#390) * Testcontainers' Mongo, and other exec-based containers, start on Kiri exec start and attach answered 101 to every client. Docker does that only for a request with an Upgrade header, and sends 200 OK with the raw stream as the body otherwise. docker-java (Testcontainers) sends none, and read no ExitCode from the exec. * e2e: exec start answers 200 without Upgrade and 101 with it --------- Co-authored-by: lucas persson <4030216+luben93@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exec startandattachanswered101 UPGRADEDto every client. Docker does that only for a clientthat sent
Upgrade: tcp(the docker CLI); to others it sends200 OKwith the raw stream as the body.docker-java, so Testcontainers, sends no
Upgrade: against Kiri it stopped reading after the lastoutput frame and inspected the exec before the exit code was recorded, which failed with a
NullPointerExceptioninexecInContainer(for exampleMongoDBContainer).http::upgrade_if_askedreplies101only to a request that has anUpgradeheader (Moby checkspresence, not the value), and
200 OKwithContent-Type: application/vnd.docker.raw-streamotherwise.The USB endpoint keeps its own
upgrade.Same change as #126 (closed), here with the exec exit-code symptom and a unit test.
Fixes #387.
Checked
cargo test -p kiri upgrades_only_when_asked: new unit test, both replies.cargo test -p kiri: all pass exceptmac_sources_follow_links_and_etc_is_the_macs, which also failson
mainon this machine (/etc/fstab).101into the200the patch sends madeTestcontainers'
MongoDBContainerstart (3 of 3 runs failed without it). The patched daemon itselfand
tests/e2e.share not run.🤖 Generated with Claude Code