Skip to content

/info reports the daemon's time, so Compose 5.7 attaches (#346) - #372

Open
Ojochogwu866 wants to merge 1 commit into
libracoder:mainfrom
Ojochogwu866:fix/346-info-system-time
Open

Ojochogwu866 wants to merge 1 commit into
libracoder:mainfrom
Ojochogwu866:fix/346-info-system-time

Conversation

@Ojochogwu866

Copy link
Copy Markdown

What this changes and why

/info never set SystemTime, so it came back empty. Compose 5.7 reads it before it attaches in docker compose up and docker compose logs -f, and stops with "the daemon reports no system time". /info now returns the daemon's current time in RFC 3339, the same format the rest of the API uses, and tests/e2e.sh checks it.

Fixes #346

How you tested it

Compose 5.7.1, a one-service project (busybox printing three lines). Before, on main:

$ docker info --format '{{.SystemTime}}'

$ docker compose up
Attaching to hello-1
reading the daemon time to subscribe to container events: the daemon reports no system time
$ docker compose logs -f
reading the daemon time to subscribe to container events: the daemon reports no system time

After, on Kiri Dev built from this branch (cargo xtask app-dev, context kiri-dev):

$ docker info --format '{{.SystemTime}}'
2026-11-16T07:09:49.916412000Z
$ docker compose up
 Container compose-346-hello-1 Started
hello-1  | tick 1
hello-1  | tick 2
hello-1  | tick 3
hello-1 exited with code 0
$ docker compose logs -f
hello-1  | tick 1
hello-1  | tick 2
hello-1  | tick 3
  • DOCKER_CONTEXT=kiri-dev tests/e2e.sh: 552 passed, 0 failed, 6 skipped (the *.kiri.localhost checks a second Kiri skips), including the new info-system-time
  • cargo test --workspace: all passed
  • python3 scripts/ui-test.py: all passed

Tested on: macOS 27.0.1, Apple silicon

How you found it

  • I use Kiri and ran into this myself
  • I found it by reading the code or comparing with Docker
  • Someone else reported it (link the issue above)

AI tools used to write this change:

Checklist

  • I have at most 3 pull requests open on Kiri, this one included
  • cargo fmt, cargo clippy and the tests pass (clippy and the tests are clean; cargo fmt --check reports the same differences on main as on this branch, none in these lines)
  • It works on macOS, Windows and Linux, or the change only touches one of them (the change is in the engine's API, which all three run; tested on macOS only)

@libracoder

Copy link
Copy Markdown
Owner

@Ojochogwu866 thanks. The fix works: SystemTime is filled in on macOS, Linux and WSL 2. This PR is still a draft, so it can't be reviewed or merged yet. It also conflicts with main now, because #371 changed the SecurityOptions line next to yours. Please rebase onto main, then mark it Ready for review when it's done.

)

Compose 5.7 reads SystemTime from /info before it attaches in `up` and
`logs -f`, and stopped with "the daemon reports no system time" when it was
empty. /info now returns it, and tests/e2e.sh checks it.
@Ojochogwu866
Ojochogwu866 force-pushed the fix/346-info-system-time branch from 53d91bc to edda0d8 Compare November 16, 2026 18:38
@Ojochogwu866
Ojochogwu866 marked this pull request as ready for review November 16, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/info returns an empty SystemTime, which breaks attached docker compose up and docker compose logs -f on Compose 5.7+

2 participants