Skip to content

build: migrate BUCK files #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genedna merged 2 commits into from
Dec 5, 2025
Merged

build: migrate BUCK files #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c09737
build: migrate BUCK files
jjl9807 Dec 5, 2025
2cc52dc
build: fix Buck2 build target name
jjl9807 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
submodules: recursive

- name: Build with Buck2
run: buck2 build //:git-internal
run: buck2 build //:git_internal

test:
name: Run Tests
Expand Down
10 changes: 5 additions & 5 deletions BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ cargo_manifest(
)

rust_library(
name = "git-internal",
name = "git_internal",

Copilot AI Dec 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name field is changed from "git-internal" to "git_internal". This is a naming inconsistency - Rust crate names typically use hyphens (-) rather than underscores (_) in BUCK/build files, even though underscores are used internally in Rust. This change may break references to this target elsewhere in the codebase that expect the hyphenated name.

Suggested change
name = "git_internal",
name = "git-internal",

Copilot uses AI. Check for mistakes.
srcs = [":git-internal-vendor"],
crate = "git_internal",
crate_root = "vendor/src/lib.rs",
Expand Down Expand Up @@ -43,7 +43,7 @@ rust_library(
"//third-party/rust/crates/futures-util/0.3.31:futures-util",
"//third-party/rust/crates/futures/0.3.31:futures",
"//third-party/rust/crates/hex/0.4.3:hex",
"//third-party/rust/crates/libc/0.2.177:libc",
"//third-party/rust/crates/libc/0.2.178:libc",
"//third-party/rust/crates/lru-mem/0.3.0:lru-mem",
"//third-party/rust/crates/memchr/2.7.6:memchr",
"//third-party/rust/crates/natord/1.0.9:natord",
Expand All @@ -62,7 +62,7 @@ rust_library(
"//third-party/rust/crates/tokio/1.48.0:tokio",
"//third-party/rust/crates/tracing-subscriber/0.3.22:tracing-subscriber",
"//third-party/rust/crates/tracing/0.1.43:tracing",
"//third-party/rust/crates/uuid/1.18.1:uuid",
"//third-party/rust/crates/uuid/1.19.0:uuid",
"//third-party/rust/crates/zstd-sys/2.0.16+zstd.1.5.7:zstd-sys",
],
)
Expand Down Expand Up @@ -96,7 +96,7 @@ rust_test(
"//third-party/rust/crates/futures-util/0.3.31:futures-util",
"//third-party/rust/crates/futures/0.3.31:futures",
"//third-party/rust/crates/hex/0.4.3:hex",
"//third-party/rust/crates/libc/0.2.177:libc",
"//third-party/rust/crates/libc/0.2.178:libc",
"//third-party/rust/crates/lru-mem/0.3.0:lru-mem",
"//third-party/rust/crates/memchr/2.7.6:memchr",
"//third-party/rust/crates/natord/1.0.9:natord",
Expand All @@ -119,7 +119,7 @@ rust_test(
"//third-party/rust/crates/tokio/1.48.0:tokio",
"//third-party/rust/crates/tracing-subscriber/0.3.22:tracing-subscriber",
"//third-party/rust/crates/tracing/0.1.43:tracing",
"//third-party/rust/crates/uuid/1.18.1:uuid",
"//third-party/rust/crates/uuid/1.19.0:uuid",
"//third-party/rust/crates/zstd-sys/2.0.16+zstd.1.5.7:zstd-sys",
],
)
244 changes: 57 additions & 187 deletions buckal.snap
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions buckal.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ignore_tests = false
33 changes: 0 additions & 33 deletions third-party/rust/crates/aes/0.8.4/BUCK
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion third-party/rust/crates/android_system_properties/0.1.5/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ rust_library(
edition = "2018",
rustc_flags = ["@$(location :android_system_properties-manifest[env_flags])"],
visibility = ["PUBLIC"],
deps = ["//third-party/rust/crates/libc/0.2.177:libc"],
deps = ["//third-party/rust/crates/libc/0.2.178:libc"],
)
1 change: 0 additions & 1 deletion third-party/rust/crates/base64/0.22.1/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ rust_library(
edition = "2018",
features = [
"alloc",
"default",
"std",
],
rustc_flags = ["@$(location :base64-manifest[env_flags])"],
Expand Down
13 changes: 5 additions & 8 deletions third-party/rust/crates/base64ct/1.6.0/BUCK → third-party/rust/crates/base64ct/1.8.0/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ load("@buckal//:wrapper.bzl", "buildscript_run", "rust_binary", "rust_library")

http_archive(
name = "base64ct-vendor",
urls = ["https://static.crates.io/crates/base64ct/base64ct-1.6.0.crate"],
sha256 = "8c3c1a368f70d6cf7302d78f8f7093da241fb8e8807c05cc9e51a125895a6d5b",
urls = ["https://static.crates.io/crates/base64ct/base64ct-1.8.0.crate"],
sha256 = "55248b47b0caf0546f7988906588779981c43bb1bc9d0c44087278f80cdb44ba",
type = "tar.gz",
strip_prefix = "base64ct-1.6.0",
strip_prefix = "base64ct-1.8.0",
out = "vendor",
)

Expand All @@ -22,11 +22,8 @@ rust_library(
srcs = [":base64ct-vendor"],
crate = "base64ct",
crate_root = "vendor/src/lib.rs",
edition = "2021",
features = [
"alloc",
"std",
],
edition = "2024",
features = ["alloc"],
rustc_flags = ["@$(location :base64ct-manifest[env_flags])"],
visibility = ["PUBLIC"],
)
24 changes: 3 additions & 21 deletions third-party/rust/crates/bindgen/0.72.1/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,7 @@ rust_library(
env = {
"OUT_DIR": "$(location :bindgen-build-script-run[out_dir])",
},
features = [
"default",
"logging",
"prettyplease",
"runtime",
],
features = ["runtime"],
rustc_flags = [
"@$(location :bindgen-build-script-run[rustc_flags])",
"@$(location :bindgen-manifest[env_flags])",
Expand All @@ -42,8 +37,6 @@ rust_library(
"//third-party/rust/crates/cexpr/0.6.0:cexpr",
"//third-party/rust/crates/clang-sys/1.8.1:clang-sys",
"//third-party/rust/crates/itertools/0.13.0:itertools",
"//third-party/rust/crates/log/0.4.28:log",
"//third-party/rust/crates/prettyplease/0.2.37:prettyplease",
"//third-party/rust/crates/proc-macro2/1.0.103:proc-macro2",
"//third-party/rust/crates/quote/1.0.42:quote",
"//third-party/rust/crates/regex/1.12.2:regex",
Expand All @@ -59,12 +52,7 @@ rust_binary(
crate = "build_script_build",
crate_root = "vendor/build.rs",
edition = "2021",
features = [
"default",
"logging",
"prettyplease",
"runtime",
],
features = ["runtime"],
rustc_flags = ["@$(location :bindgen-manifest[env_flags])"],
visibility = [],
)
Expand All @@ -75,15 +63,9 @@ buildscript_run(
buildscript_rule = ":bindgen-build-script-build",
env_srcs = [
"//third-party/rust/crates/clang-sys/1.8.1:clang-sys-build-script-run[metadata]",
"//third-party/rust/crates/prettyplease/0.2.37:prettyplease-build-script-run[metadata]",
":bindgen-manifest[env_dict]",
],
features = [
"default",
"logging",
"prettyplease",
"runtime",
],
features = ["runtime"],
version = "0.72.1",
manifest_dir = ":bindgen-vendor",
visibility = ["PUBLIC"],
Expand Down
30 changes: 0 additions & 30 deletions third-party/rust/crates/block-padding/0.3.3/BUCK
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions ...party/rust/crates/borsh-derive/1.5.7/BUCK → ...party/rust/crates/borsh-derive/1.6.0/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ load("@buckal//:wrapper.bzl", "buildscript_run", "rust_binary", "rust_library")

http_archive(
name = "borsh-derive-vendor",
urls = ["https://static.crates.io/crates/borsh-derive/borsh-derive-1.5.7.crate"],
sha256 = "fdd1d3c0c2f5833f22386f252fe8ed005c7f59fdcddeef025c01b4c3b9fd9ac3",
urls = ["https://static.crates.io/crates/borsh-derive/borsh-derive-1.6.0.crate"],
sha256 = "0686c856aa6aac0c4498f936d7d6a02df690f614c03e4d906d1018062b5c5e2c",
type = "tar.gz",
strip_prefix = "borsh-derive-1.5.7",
strip_prefix = "borsh-derive-1.6.0",
out = "vendor",
)

Expand Down
10 changes: 5 additions & 5 deletions third-party/rust/crates/borsh/1.5.7/BUCK → third-party/rust/crates/borsh/1.6.0/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ load("@buckal//:wrapper.bzl", "buildscript_run", "rust_binary", "rust_library")

http_archive(
name = "borsh-vendor",
urls = ["https://static.crates.io/crates/borsh/borsh-1.5.7.crate"],
sha256 = "ad8646f98db542e39fc66e68a20b2144f6a732636df7c2354e74645faaa433ce",
urls = ["https://static.crates.io/crates/borsh/borsh-1.6.0.crate"],
sha256 = "d1da5ab77c1437701eeff7c88d968729e7766172279eab0676857b3d63af7a6f",
type = "tar.gz",
strip_prefix = "borsh-1.5.7",
strip_prefix = "borsh-1.6.0",
out = "vendor",
)

Expand Down Expand Up @@ -37,7 +37,7 @@ rust_library(
"@$(location :borsh-manifest[env_flags])",
],
visibility = ["PUBLIC"],
deps = ["//third-party/rust/crates/borsh-derive/1.5.7:borsh-derive"],
deps = ["//third-party/rust/crates/borsh-derive/1.6.0:borsh-derive"],
)

rust_binary(
Expand Down Expand Up @@ -68,7 +68,7 @@ buildscript_run(
"std",
"unstable__schema",
],
version = "1.5.7",
version = "1.6.0",
manifest_dir = ":borsh-vendor",
visibility = ["PUBLIC"],
)
33 changes: 0 additions & 33 deletions third-party/rust/crates/cbc/0.1.2/BUCK
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion third-party/rust/crates/cc/1.2.45/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ rust_library(
deps = [
"//third-party/rust/crates/find-msvc-tools/0.1.4:find-msvc-tools",
"//third-party/rust/crates/jobserver/0.1.34:jobserver",
"//third-party/rust/crates/libc/0.2.177:libc",
"//third-party/rust/crates/libc/0.2.178:libc",
"//third-party/rust/crates/shlex/1.3.0:shlex",
],
)
33 changes: 0 additions & 33 deletions third-party/rust/crates/cipher/0.4.4/BUCK
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion third-party/rust/crates/clang-sys/1.8.1/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ rust_library(
visibility = ["PUBLIC"],
deps = [
"//third-party/rust/crates/glob/0.3.3:glob",
"//third-party/rust/crates/libc/0.2.177:libc",
"//third-party/rust/crates/libc/0.2.178:libc",
"//third-party/rust/crates/libloading/0.8.9:libloading",
],
)
Expand Down
6 changes: 3 additions & 3 deletions third-party/rust/crates/crc/3.3.0/BUCK → third-party/rust/crates/crc/3.4.0/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ load("@buckal//:wrapper.bzl", "buildscript_run", "rust_binary", "rust_library")

http_archive(
name = "crc-vendor",
urls = ["https://static.crates.io/crates/crc/crc-3.3.0.crate"],
sha256 = "9710d3b3739c2e349eb44fe848ad0b7c8cb1e42bd87ee49371df2f7acaf3e675",
urls = ["https://static.crates.io/crates/crc/crc-3.4.0.crate"],
sha256 = "5eb8a2a1cd12ab0d987a5d5e825195d372001a4094a0376319d5a0ad71c1ba0d",
type = "tar.gz",
strip_prefix = "crc-3.3.0",
strip_prefix = "crc-3.4.0",
out = "vendor",
)

Expand Down
2 changes: 1 addition & 1 deletion third-party/rust/crates/errno/0.3.14/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ rust_library(
features = ["std"],
rustc_flags = ["@$(location :errno-manifest[env_flags])"],
visibility = ["PUBLIC"],
deps = ["//third-party/rust/crates/libc/0.2.177:libc"],
deps = ["//third-party/rust/crates/libc/0.2.178:libc"],
)
Loading