Skip to content

Wallet and daemon rpc fixes - #68

Merged
everoddandeven merged 1 commit into
mainfrom
wallet-rpc-consolidation
Mar 20, 2026
Merged

everoddandeven merged 1 commit into
mainfrom
wallet-rpc-consolidation

Conversation

@everoddandeven

@everoddandeven everoddandeven commented Mar 19, 2026 •

Copy link
Copy Markdown
Member
  • Fix PyMoneroTx::from_property_tree tx fee deserialization
  • Fix PyMoneroDaemon::get_miner_tx_sum
  • Fix PyMoneroTxWallet::from_property_tree_with_transfer
  • Fix PyMoneroWalletRpc::check_tx_proof
  • Fix PyMoneroWalletRpc::sweep_account
  • Fix PyMoneroWalletRpc::get_transfers_aux
  • Fix PyMoneroWalletRpc::close
  • Implement PyMoneroWalletRpc::is_closed
  • Consolidate PyMoneroDaemonRpc::get_tx_pool_hashes
  • Remove AssertUtils.assert_equals for simple comparison
  • Set --rpc-max-connections-per-private-ip=100 in monero-wallet-rpc docker containers
  • Re-enable rpc wallet tests that were failing for Network error
  • Set config sync_period_in_ms=2500

@everoddandeven
everoddandeven force-pushed the wallet-rpc-consolidation branch from 896749e to 9f6c347 Compare March 20, 2026 00:40
* Fix `PyMoneroTx::from_property_tree` tx fee deserialization
* Fix `PyMoneroDaemon::get_miner_tx_sum`
* Fix `PyMoneroTxWallet::from_property_tree_with_transfer`
* Fix `PyMoneroWalletRpc::check_tx_proof`
* Fix `PyMoneroWalletRpc::sweep_account`
* Fix `PyMoneroWalletRpc::get_transfers_aux`
* Fix `PyMoneroWalletRpc::close`
* Implement `PyMoneroWalletRpc::is_closed`
* Consolidate `PyMoneroDaemonRpc::get_tx_pool_hashes`
* Remove `AssertUtils.assert_equals` for simple comparison
* Set `--rpc-max-connections-per-private-ip=100` in `monero-wallet-rpc` docker containers
* Re-enable rpc wallet tests that were failing for Network error
* Set config `sync_period_in_ms=2500`
@everoddandeven
everoddandeven force-pushed the wallet-rpc-consolidation branch from 9f6c347 to 6f1bb12 Compare March 20, 2026 00:49
@codacy-production

codacy-production Bot commented Mar 20, 2026 •

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.80% (target: -1.00%) ✅ 92.90%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7929e9b) 18291 15328 83.80%
Head commit (6f1bb12) 18325 (+34) 15504 (+176) 84.61% (+0.80%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#68) 155 144 92.90%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@everoddandeven
everoddandeven merged commit 55ea7a7 into main Mar 20, 2026
4 of 5 checks passed
@everoddandeven
everoddandeven deleted the wallet-rpc-consolidation branch March 20, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant