Skip to content

Consolidate daemon rpc tx pool interaction - #60

Merged
everoddandeven merged 1 commit into
mainfrom
daemon-rpc-consolidation-3
Mar 14, 2026
Merged

everoddandeven merged 1 commit into
mainfrom
daemon-rpc-consolidation-3

Conversation

@everoddandeven

Copy link
Copy Markdown
Member
  • Add daemon rpc tests test_get_txs_by_hashes_in_pool, test_get_tx_hex_by_hash, test_get_tx_hexes_by_hashes, test_get_txs_in_pool, test_flush_txs_from_pool, test_flush_tx_from_pool_by_hash, test_flush_txs_from_pool_by_hashes, test_get_spent_status_of_key_images, test_get_output_histogram_binary, test_get_output_distribution_binary
  • Fix PyMoneroDaemonRpc::get_output_histogram, PyMoneroOutputHistogramEntry::from_property_tree,
  • Implement PyMoneroDaemonRpc::get_tx_hexes, PyMoneroTx::from_property_tree

* Add daemon rpc tests `test_get_txs_by_hashes_in_pool`, `test_get_tx_hex_by_hash`, `test_get_tx_hexes_by_hashes`, `test_get_txs_in_pool`, `test_flush_txs_from_pool`,  `test_flush_tx_from_pool_by_hash`, `test_flush_txs_from_pool_by_hashes`, `test_get_spent_status_of_key_images`, `test_get_output_histogram_binary`, `test_get_output_distribution_binary`
* Fix `PyMoneroDaemonRpc::get_output_histogram`, `PyMoneroOutputHistogramEntry::from_property_tree`,
* Implement `PyMoneroDaemonRpc::get_tx_hexes`, `PyMoneroTx::from_property_tree`
@codacy-production

codacy-production Bot commented Mar 14, 2026 •

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.94% (target: -1.00%) ✅ 91.39%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (88fb4d4) 16987 13874 81.67%
Head commit (ef39014) 17289 (+302) 14283 (+409) 82.61% (+0.94%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#60) 337 308 91.39%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@everoddandeven
everoddandeven merged commit b39a273 into main Mar 14, 2026
5 checks passed
@everoddandeven
everoddandeven deleted the daemon-rpc-consolidation-3 branch March 14, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant