Skip to content

Fix wallet sweep - #54

Merged
everoddandeven merged 1 commit into
mainfrom
sweep-wallet
Mar 8, 2026
Merged

everoddandeven merged 1 commit into
mainfrom
sweep-wallet

Conversation

@everoddandeven

Copy link
Copy Markdown
Member
  • Add test_sweep_outputs, test_sweep_dust_no_relay, test_sweep_dust, test_sweep_subaddresses, test_sweep_accounts, test_sweep_wallet_by_accounts, test_sweep_wallet_by_subaddresses
  • Fix PyMoneroTxWallet::init_sent, PyMoneroTxWallet::from_property_tree_with_transfer, PyMoneroTxSet::from_property_tree
  • Reenable wallet rpc tests test_subtract_fee_from

* Add `test_sweep_outputs`, `test_sweep_dust_no_relay`, `test_sweep_dust`, `test_sweep_subaddresses`, `test_sweep_accounts`, `test_sweep_wallet_by_accounts`, `test_sweep_wallet_by_subaddresses`
* Fix `PyMoneroTxWallet::init_sent`, `PyMoneroTxWallet::from_property_tree_with_transfer`, `PyMoneroTxSet::from_property_tree`
* Reenable wallet rpc tests `test_subtract_fee_from`
@codacy-production

codacy-production Bot commented Mar 8, 2026 •

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.44% (target: -1.00%) ✅ 93.26%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fbc38e6) 16394 13082 79.80%
Head commit (0145a29) 16716 (+322) 13413 (+331) 80.24% (+0.44%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#54) 341 318 93.26%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@everoddandeven
everoddandeven merged commit 9f83925 into main Mar 8, 2026
5 checks passed
@everoddandeven
everoddandeven deleted the sweep-wallet branch March 8, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant