Skip to content

Add other basic common wallet tests - #39

Merged
everoddandeven merged 1 commit into
mainfrom
minor-tests
Jan 26, 2026
Merged

everoddandeven merged 1 commit into
mainfrom
minor-tests

Conversation

@everoddandeven

@everoddandeven everoddandeven commented Jan 25, 2026 •

Copy link
Copy Markdown
Member

Add other wallet common tests and fixes

  • Added tests test_get_daemon_max_peer_height, test_daemon, test_change_password, test_save_and_close
  • Bind missing PyMoneroSslOptions struct
  • Fix PyMoneroWallet::get_attribute binding
  • Bind PyMoneroWalletRpc::set_daemon_connection with trusted option
  • Fix PyMoneroCloseWalletParams and PyMoneroWalletAttributeParams

@everoddandeven
everoddandeven force-pushed the minor-tests branch 4 times, most recently from 4758f43 to 02c65d4 Compare January 26, 2026 17:04
* Added tests `test_get_daemon_max_peer_height`, `test_daemon`, `test_change_password`, `test_save_and_close` and fix related logic
* Bind missing PyMoneroSslOptions struct
* Fix PyMoneroWallet::get_attribute binding
* Bind PyMoneroWalletRpc::set_daemon_connection with trusted option
* Fix PyMoneroCloseWalletParams and PyMoneroWalletAttributeParams
@codacy-production

codacy-production Bot commented Jan 26, 2026 •

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.52% (target: -1.00%) ✅ 87.60%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (567ec1c) 11856 7229 60.97%
Head commit (da45716) 11967 (+111) 7359 (+130) 61.49% (+0.52%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#39) 129 113 87.60%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@everoddandeven
everoddandeven merged commit d571f58 into main Jan 26, 2026
5 of 7 checks passed
@everoddandeven
everoddandeven deleted the minor-tests branch January 26, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant