Skip to content

KdTree: Disable optimizations in latest MSVC version#1453

Merged
dbaston merged 2 commits into
libgeos:mainfrom
dbaston:kdtree-disable-msvc-opt
Jun 19, 2026
Merged

KdTree: Disable optimizations in latest MSVC version#1453
dbaston merged 2 commits into
libgeos:mainfrom
dbaston:kdtree-disable-msvc-opt

Conversation

@dbaston

@dbaston dbaston commented Jun 18, 2026

Copy link
Copy Markdown
Member

Workaround for #1449

@pramsey pramsey self-requested a review June 18, 2026 19:29
@rouault

rouault commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

has anyone tried to report it to Microsoft as it smells now as a quite likely optimizer bug. Although the code in that function looks to me as super boring (not like math stuff were you could have autovectorizer bugs...)

@mwtoews mwtoews left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might also be a good idea to add a comment with a link to https://github.com/libgeos/geos/issues/1449 as this bug will likely be resolved with a future compiler update and this logic will need to be revised.

Comment thread src/index/kdtree/KdTree.cpp Outdated
Comment thread src/index/kdtree/KdTree.cpp Outdated
@dbaston dbaston force-pushed the kdtree-disable-msvc-opt branch 2 times, most recently from 6146e32 to 19ba810 Compare June 19, 2026 13:28
@dbaston

dbaston commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

has anyone tried to report it to Microsoft

It's not clear to me where you would do so, do they really just track these kinds of these kinds of things in the Developer Community forum?

b0689cb adds a minimal example to provoke the failure. It's as basic as a CS 101 example, I would think a compiler bug affecting this would be blowing up code all over the place. Bizarre.

@dbaston dbaston force-pushed the kdtree-disable-msvc-opt branch from 19ba810 to 4226b5a Compare June 19, 2026 13:42
@rouault

rouault commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

do they really just track these kinds of these kinds of things in the Developer Community forum?

yes I believe that's the only place where us mortals can report and hope for the best...

@dbaston dbaston merged commit 4226b5a into libgeos:main Jun 19, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants