Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the database from SQLite to MySQL and replaces the third-party WebSocket library with a custom WebSocket implementation. Key changes include implementing a MySQL connection pool architecture, new repository pattern for database operations, and maintaining the existing WebSocket functionality with custom code.
- Database migration from SQLite to MySQL with connection pooling and repository pattern
- Removal of third-party websocketpp dependency and implementation of custom WebSocket handling
- Code formatting improvements and header reorganization across utility and test files
Reviewed Changes
Copilot reviewed 91 out of 92 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| third_party/websocketpp | Removed third-party WebSocket library submodule |
| tests/utils/*.cpp | Code formatting improvements and header reorganization |
| tests/model/*.cpp | Updated model tests to use integer IDs and new field structures |
| tests/http/test_http_server.cpp | Removed HTTP server tests (file deleted) |
| tests/http/*.cpp | Code formatting improvements |
| tests/db/*.cpp | New database tests for MySQL repositories and connection management |
| tests/CMakeLists.txt | Updated build configuration for new MySQL-based tests |
| src/websocket/*.hpp/.cpp | Code formatting and header reorganization |
| src/utils/*.hpp/.cpp | Code formatting improvements and new SHA1 utility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| #include "../../src/db/respository/room_repository.hpp" | ||
| #include "../../src/db/respository/user_repository.hpp" |
There was a problem hiding this comment.
Typo in directory name: respository should be repository in both include paths.
| #include "../../src/db/respository/room_repository.hpp" | |
| #include "../../src/db/respository/user_repository.hpp" | |
| #include "../../src/db/repository/room_repository.hpp" | |
| #include "../../src/db/repository/user_repository.hpp" |
| # 创建用户仓库测试可执行文件 | ||
| add_executable(test_user_repository | ||
| db/test_user_repository.cpp | ||
| ../src/db/respository/user_repository.cpp |
There was a problem hiding this comment.
Typo in directory name: respository should be repository in all source file paths.
No description provided.