Repository navigation
recorded_precursor_ms1 on both readers - #23
Merged
Merged
Conversation
…ed, with the fallback reason MzMLReader now reads the precursor's spectrumRef (the cache already stored it). The recorded scan is used when it exists and is MS1; otherwise the nearest earlier MS1 is returned with 'nearest_preceding:<reason>'. find_best_ms1 (strongest of the neighbours) is unchanged. Tested on a hand-written mzML and the cache built from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MS1 scan the instrument recorded for an MSn scan (spectrumRef), with a stated fallback reason; parity between MzMLReader and SpectrumCache tested on a hand-written mzML.
🤖 Generated with Claude Code