Repository navigation
Fix the Y0-H2O sign in GLYCAN_Y_LOSSES - #20
Merged
Merged
Conversation
The table listed the Y0-H2O loss as glycan - H2O, so calculate_Y_ions put the ion labelled Y0-H2O at Y0 + H2O/z, 36.02 Da above its target. The loss is glycan + H2O. Same defect and fix as GlycoSpectrumAnnotator's copy. Found by the OGlyco_DBA GPT toolchain review (finding 11). Verified: the new test fails before the fix and passes after; the full suite passes (258). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GLYCAN_Y_LOSSES put the Y0-H2O ion at Y0 + H2O/z. The loss is glycan + H2O. New test asserts Y0 - (Y0-H2O) = 18.0106/z at z = 1, 2.
🤖 Generated with Claude Code