Repository navigation
peak_metrics(bridge_dropouts=k) and a public bridge_dropouts() - #19
Merged
Merged
Conversation
…aries agree with find_peaks find_peaks bridged one-scan dropouts; peak_metrics did not, so on the same zero-filled trace the enclosing peak ended at the first empty scan while the peak list ran through it. On NGlycoM012 F21 that was most of the "partial overlap" between the QC's peak and IonQuant's feature (880 of 1,354: IonQuant's wider feature held our apex, our dropout-cut peak missed its apex). bridge_dropouts(intensity, max_gap) is the one implementation both use. With bridge_dropouts > 0 every peak_metrics value comes from the bridged trace except n_signal, which counts scans with the ion in the original. Default 0 is R. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
peak_metrics(bridge_dropouts=k) and a public bridge_dropouts()