Repository navigation
Window-edge test casts the target to float32 explicitly (CI fix) - #15
Merged
Merged
Conversation
…under every NumPy CI (both Pythons) passed the fix itself -- `_window_intensity` matched the float64 reference on every target -- but failed the test's "has teeth" assertion: its float32 reference relied on `float32_array - python_float` staying float32, which held locally and not on CI's NumPy, so no disagreement was ever recorded there. The reference now rounds the target to float32 itself, which is the behaviour the fix guards against, independent of promotion rules. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Window-edge test casts the target to float32 explicitly (CI fix)