fix(layout): hit-test atomic inlines in front of wrapping inline boxes - #395
Open
BibekPathak wants to merge 2 commits into
Open
fix(layout): hit-test atomic inlines in front of wrapping inline boxes#395BibekPathak wants to merge 2 commits into
BibekPathak wants to merge 2 commits into
Conversation
Contributor
Author
|
Hey @ldm0 , check this out!! |
ldm0
self-requested a review
September 5, 2026 19:28
…tent_clips[index] when promoting the atomic's box fragment
BibekPathak
force-pushed
the
fix_layout
branch
from
September 6, 2026 05:12
0d85960 to
8f830ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a normal-flow
<label>text <input></label>the atomic<input>boxfragment only received a background-phase hit paint order, so the
wrapping
<label>'s contents-phase InlineBox fragment occluded all but athin strip of the input in tree hit testing (DOM.getNodeForLocation
returned the label inside the input box). Promote a non-flattened atomic
inline's own box fragment to the contents phase at its BoxContents event,
so a point inside the atomic resolves to the atomic while the enclosing
inline still wins outside it. paint_order is hit-test-only, so rendering
is unchanged.