Skip to content

fix(analytics): preserve gtag command arguments #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiongxz merged 1 commit into from
Sep 7, 2026
Merged

fix(analytics): preserve gtag command arguments #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion admin-dashboard/src/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId
window.dataLayer = window.dataLayer || []
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args))
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
}
window.gtag('js', new Date())
analyticsContext = safeProperties(commonProperties(runtime))
window.gtag('set', analyticsContext)
Expand Down
4 changes: 3 additions & 1 deletion ai-pdf-chatbot/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId;
window.dataLayer = window.dataLayer || [];
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args));
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
};
window.gtag('js', new Date());
analyticsContext = safeProperties(commonProperties(runtime));
window.gtag('set', analyticsContext);
Expand Down
4 changes: 3 additions & 1 deletion booking/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId;
window.dataLayer = window.dataLayer || [];
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args));
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
};
window.gtag('js', new Date());
analyticsContext = safeProperties(commonProperties(runtime));
window.gtag('set', analyticsContext);
Expand Down
4 changes: 3 additions & 1 deletion chatbot/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId;
window.dataLayer = window.dataLayer || [];
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args));
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
};
window.gtag('js', new Date());
analyticsContext = safeProperties(commonProperties(runtime));
window.gtag('set', analyticsContext);
Expand Down
4 changes: 3 additions & 1 deletion crm/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId;
window.dataLayer = window.dataLayer || [];
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args));
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
};
window.gtag('js', new Date());
analyticsContext = safeProperties(commonProperties(runtime));
window.gtag('set', analyticsContext);
Expand Down
4 changes: 3 additions & 1 deletion e-commerce/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId;
window.dataLayer = window.dataLayer || [];
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args));
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
};
window.gtag('js', new Date());
analyticsContext = safeProperties(commonProperties(runtime));
window.gtag('set', analyticsContext);
Expand Down
4 changes: 3 additions & 1 deletion insight-flow-agent-chat/src/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId
window.dataLayer = window.dataLayer || []
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args))
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
}
window.gtag('js', new Date())
analyticsContext = safeProperties(commonProperties(runtime))
window.gtag('set', analyticsContext)
Expand Down
4 changes: 3 additions & 1 deletion landing/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId;
window.dataLayer = window.dataLayer || [];
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args));
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
};
window.gtag('js', new Date());
analyticsContext = safeProperties(commonProperties(runtime));
window.gtag('set', analyticsContext);
Expand Down
4 changes: 3 additions & 1 deletion nextjs/src/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId;
window.dataLayer = window.dataLayer || [];
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args));
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
};
window.gtag('js', new Date());
analyticsContext = safeProperties(commonProperties(runtime));
window.gtag('set', analyticsContext);
Expand Down
4 changes: 3 additions & 1 deletion react/src/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId
window.dataLayer = window.dataLayer || []
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args))
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
}
window.gtag('js', new Date())
analyticsContext = safeProperties(commonProperties(runtime))
window.gtag('set', analyticsContext)
Expand Down
4 changes: 4 additions & 0 deletions scripts/check-analytics.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ for (const name of templates) {
assert(helperSource.includes('__INSFORGE_RUNTIME_CONFIG__'), `${name}: runtime config is not preferred`);
assert(helperSource.includes('gaMeasurementId'), `${name}: runtime GA4 measurement ID is missing`);
assert(helperSource.includes('googletagmanager.com/gtag/js'), `${name}: Google tag is not loaded`);
assert(helperSource.includes('window.dataLayer?.push(arguments)'),
`${name}: gtag commands must preserve the Arguments object expected by Google`);
assert(!helperSource.includes('window.dataLayer?.push(args)'),
`${name}: array-wrapped gtag commands are ignored by Google`);
assert(helperSource.includes('send_page_view: false'), `${name}: automatic and manual page views may be duplicated`);
assert(helperSource.includes("'page_view'"), `${name}: page views are not captured`);
assert(helperSource.includes('window.location.pathname'), `${name}: page paths are not sanitized`);
Expand Down
4 changes: 3 additions & 1 deletion todo/src/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId;
window.dataLayer = window.dataLayer || [];
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args));
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
};
window.gtag('js', new Date());
analyticsContext = safeProperties(commonProperties(runtime));
window.gtag('set', analyticsContext);
Expand Down
4 changes: 3 additions & 1 deletion web-research-agent/src/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId
window.dataLayer = window.dataLayer || []
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args))
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
}
window.gtag('js', new Date())
analyticsContext = safeProperties(commonProperties(runtime))
window.gtag('set', analyticsContext)
Expand Down
4 changes: 3 additions & 1 deletion website-change-monitor/src/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId
window.dataLayer = window.dataLayer || []
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args))
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
}
window.gtag('js', new Date())
analyticsContext = safeProperties(commonProperties(runtime))
window.gtag('set', analyticsContext)
Expand Down
4 changes: 3 additions & 1 deletion workspace/lib/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ export function initializeAnalytics(): void {

measurementId = configuredId;
window.dataLayer = window.dataLayer || [];
window.gtag = window.gtag || ((...args: unknown[]) => window.dataLayer?.push(args));
window.gtag = window.gtag || function (..._args: unknown[]) {
window.dataLayer?.push(arguments)
};
window.gtag('js', new Date());
analyticsContext = safeProperties(commonProperties(runtime));
window.gtag('set', analyticsContext);
Expand Down
Loading