fix: reject prototype paths, fail closed on deny, and run unit tests in CI - #70
Open
martijn00 wants to merge 1 commit into
Open
fix: reject prototype paths, fail closed on deny, and run unit tests in CI#70martijn00 wants to merge 1 commit into
martijn00 wants to merge 1 commit into
Conversation
|
@martijn00 is attempting to deploy a commit to the letstri Team on Vercel. A member of the Team first needs to authorize it. |
8 tasks
…in CI check() and ~any/~all only walk own properties, so inherited names such as `constructor` or `toString` can no longer resolve as rules. hydrate() skips `__proto__` keys from untrusted JSON. An empty subtree denies `~all`. Fastify and Elysia respond 403 when a custom onForbidden neither replies nor returns. Express and Node forward async setup/check errors to next(err). Add a Test workflow so pnpm test runs on every PR. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
letstri
force-pushed
the
fix/prototype-safe-check-and-ci
branch
from
September 6, 2026 06:50
b98cd77 to
d7c54e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Object.prototypenames and__proto__hydrate keys socheck()cannot authorize via the prototype chainsetup()/hydrate()so mutating the caller object orgetRules()cannot change authorizationnext(err)~allas deny, and runpnpm teston every PRTest plan
pnpm exec vitest run src/core src/fastify src/elysia src/express src/node src/extractorpnpm testpnpm run check-typespnpm run lintpnpm run format:checkChecklist
__proto__hydrate, empty~all, reserved extractor segments, no-oponForbidden, and rejecting setup