fix: read hydrated permissions on first Solid, Svelte, and Vue render - #55
Open
martijn00 wants to merge 2 commits into
Open
fix: read hydrated permissions on first Solid, Svelte, and Vue render#55martijn00 wants to merge 2 commits into
martijn00 wants to merge 2 commits into
Conversation
Subscribe to setup/ready during render instead of after an effect so dehydrated booleans and already-initialized rules are visible on the first paint. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@martijn00 is attempting to deploy a commit to the letstri Team on Vercel. A member of the Team first needs to authorize it. |
Toolchain skills from skills.sh fail format check and are not project source. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solid, Svelte, and Vue used to subscribe to
setup/readyin an effect, so the first paint after dehydrate or aftersetup()before mount could miss the rules that were already there. They now subscribe during render (SolidcreateRenderEffect, SvelteonDestroyinstead of$effect, Vue tests covering the same first-paint path).Dehydrated boolean checks show up on the first render.
isReadyis true immediately whensetup()already ran. Independent of the React/Next stack — can merge againstmainas soon as CI is green.Test plan
pnpm --filter permix exec vitest run src/solid src/svelte src/vuetrue:false(allowed + not ready) on first render