Conversation
lescuer97
reviewed
May 8, 2026
|
|
||
| "github.com/gin-gonic/gin" | ||
| "github.com/gin-gonic/gin/render" | ||
| jsonv2 "github.com/go-json-experiment/json" |
Owner
There was a problem hiding this comment.
this is not the correct dependency. this is the correct V2 https://pkg.go.dev/encoding/json/v2
We don't want to add a dependency that is not STD if not needed.
lescuer97
reviewed
May 8, 2026
lescuer97
left a comment
lescuer97
left a comment
Owner
There was a problem hiding this comment.
Thank you for the contribution!
the utils approach seems to be fine but they json dependency is incorrect. also you wil probably need some adjustment to the justfile because of this feature still needing to be experimental
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#241