fix: apply escape flag to a user-supplied HTML renderer - #471
Merged
lepture merged 1 commit intoJul 25, 2026
Merged
Conversation
create_markdown() only passed the escape flag to the renderer it built itself, so passing escape=False together with a custom HTMLRenderer subclass silently left HTML escaped. escape now defaults to None, meaning 'keep the renderer's own setting', and an explicit True/False is applied to a supplied HTMLRenderer instance as well. Closes lepture#420
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 36 36
Lines 3629 3631 +2
Branches 676 677 +1
=======================================
+ Hits 3309 3311 +2
Misses 193 193
Partials 127 127 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #420
create_markdown()only passedescapeto the renderer it constructed itself, socreate_markdown(renderer=MyRenderer(), escape=False)silently kept escaping HTML.escapenow defaults toNone("keep the renderer's own setting") and an explicitTrue/Falseis applied to a suppliedHTMLRendererinstance too. Existing calls are unaffected: the default renderer still escapes by default.