Skip to content

Fix overzealous html decoding in mistune 2.x - #452

Merged
lepture merged 7 commits into
lepture:v2from
dairiki:fix.448-overzealous-html-decoding
Jun 18, 2026
Merged

Fix overzealous html decoding in mistune 2.x#452
lepture merged 7 commits into
lepture:v2from
dairiki:fix.448-overzealous-html-decoding

Conversation

@dairiki

@dairiki dairiki commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This fixes #448 in which mistune 2.x (when running under python 3) is overzealous about unescaping HTML entities.

dairiki added 7 commits June 17, 2026 14:44
The matrix included os variants, but they were being ignored.  All
jobs are being run on `ubuntu-latest` (linux), regardless of the value
of `matrix.os`.
Instead of running pytest twice, once to "test", once to collect
coverage data, just collect coverage data during the initial run.
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.03%. Comparing base (cb580e8) to head (09f566e).

Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #452      +/-   ##
==========================================
- Coverage   99.43%   99.03%   -0.40%     
==========================================
  Files          19       19              
  Lines        1244     1248       +4     
==========================================
- Hits         1237     1236       -1     
- Misses          7       12       +5     
Flag Coverage Δ
unittests 99.03% <100.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

@dairiki

dairiki commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

I've put some effort into fixing the CI tests so that they run in the modern day.

Some (or perhaps all) of the codecov upload steps are failing, which, I suspect, is the cause of the test failure for decreasing code coverage. It appears that, at the least, the python 2.7 coverage reports are not being uploaded to codecov.

@lepture
lepture merged commit f1221ce into lepture:v2 Jun 18, 2026
12 of 13 checks passed
@lepture

lepture commented Jun 21, 2026

Copy link
Copy Markdown
Owner

Released in 2.1.0

@dairiki

dairiki commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@lepture Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants