fixed issue13#46
Open
MarkChenYutian wants to merge 1 commit intoleopardslab:masterfrom
MarkChenYutian:issue13
Open
fixed issue13#46MarkChenYutian wants to merge 1 commit intoleopardslab:masterfrom MarkChenYutian:issue13
MarkChenYutian wants to merge 1 commit intoleopardslab:masterfrom
MarkChenYutian:issue13
Conversation
Author
TRomesh
requested changes
Dec 31, 2019
Collaborator
TRomesh
left a comment
TRomesh
left a comment
There was a problem hiding this comment.
Noticed that you have changed nc to nodec any particular reason for that change?. We used "nc" so when we publish this library as cli we can call it by "nc". Apart from that you code looks good.
* added --pretty flag for cli * refactored logger function in helper.js to take one more parameter for prettification * refactored logger calls in services.js * added cli-table3 as dependency
Author
|
@TRomesh I reset and changed the unintended line back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prettification