Skip to content

Feat/enhance copy mode#106

Open
BrettKulp wants to merge 7 commits intoleohenon:ocvfrom
BrettKulp:feat/enhance_copy_mode_new
Open

Feat/enhance copy mode#106
BrettKulp wants to merge 7 commits intoleohenon:ocvfrom
BrettKulp:feat/enhance_copy_mode_new

Conversation

@BrettKulp
Copy link
Copy Markdown

fixes the flashing issue when entering copy mode and cursor sometimes not visible when entering copy mode in #79 for #50 and synced with recent changes

add ctrl + w j/k for entering and exiting copy mode without scrolling the chat history. The cursor will enter into a row that is already visible in the chat history if the chat is scrolled up to previous older messages. Leader + v, esc, and q still scroll chat history while entering and exiting as before.

Entering and exiting copy mode via ctr + w + j/k if will enter into a visible section of chat history

Copy link
Copy Markdown
Owner

@leohenon leohenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better, but I still see a few issues:

  • Ctrl+W pending state is never cleared, so pressing something like Ctrl+W x can stay stuck pending.

  • Using hasModifier(event) also captures Alt+W / Meta+W / Super+W instead of only Ctrl+W.

  • README says visual y stays in copy mode, but the implementation still exits copy mode after yanking, which is correct but the README should be updated.

  • This includes changes unrelated to copy mode, please rebase and keep only relevant changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants