Feat/enhance copy mode#106
Open
BrettKulp wants to merge 7 commits intoleohenon:ocvfrom
Open
Conversation
leohenon
requested changes
May 8, 2026
Owner
leohenon
left a comment
There was a problem hiding this comment.
This is better, but I still see a few issues:
-
Ctrl+Wpending state is never cleared, so pressing something likeCtrl+W xcan stay stuck pending. -
Using
hasModifier(event)also capturesAlt+W/Meta+W/Super+Winstead of onlyCtrl+W. -
README says visual
ystays in copy mode, but the implementation still exits copy mode after yanking, which is correct but the README should be updated. -
This includes changes unrelated to copy mode, please rebase and keep only relevant changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the flashing issue when entering copy mode and cursor sometimes not visible when entering copy mode in #79 for #50 and synced with recent changes
add ctrl + w j/k for entering and exiting copy mode without scrolling the chat history. The cursor will enter into a row that is already visible in the chat history if the chat is scrolled up to previous older messages. Leader + v, esc, and q still scroll chat history while entering and exiting as before.
Entering and exiting copy mode via ctr + w + j/k if will enter into a visible section of chat history