feat(skills): add precision-over-recall review discipline and learn necessity gate - #14
Merged
Merged
Conversation
…ecessity gate - Add Precision Discipline section to rules/common/code-review.md (5 gate-keeping rules) - Add Precision gate subsection to 04-review SKILL.md - Add Necessity gate to 05-learn SKILL.md (decide FIRST whether to preserve) - Add rules/golang/review-checklist.md and rules/python/review-checklist.md with battle-tested defect patterns (absorbed from alibaba/open-code-review) - Update rules/README.md to document review-checklist.md file type - Bump version to 0.27.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
吸纳 alibaba/open-code-review 经实战验证的设计哲学，增强 super-pi 的代码审查与知识沉淀纪律。遵循极简原则——只吸收知识层面价值，不做代码级融合。
审查哲学（precision-over-recall）
rules/common/code-review.md：新增 Precision Discipline 节，5 条门禁规则（先验证再断言、不重复确定性工具、上下文不清时沉默、区分阻断/非阻断、不盲从最佳实践）skills/04-review/SKILL.md：新增 Precision gate 子节，指导 reviewer 在证据不足时保持沉默rules/golang/review-checklist.md+rules/python/review-checklist.md（新文件类型）：精确的语言专属缺陷模式，每条附"不报"边界。与patterns.md（设计模式）职责分离rules/README.md：同步更新文件类型契约说明知识沉淀门禁（necessity gate）
skills/05-learn/SKILL.md：新增 Necessity gate 作为第一道决策——多数已解决的问题不值得沉淀。明确值得沉淀的标准（非平凡 + 可复用 + 未已在别处记录）与一票否决红线。"沉默可接受，噪音不行。"变更范围
测试
bun test：204 pass / 0 failbunx tsc --noEmit：1 个预先存在的错误（与本次改动无关，全部改动为 markdown 文档）版本
bump
0.26.0→0.27.0（MINOR，新增功能）