fix(skills): external-resource verification + Spec axis traceback - #12
Merged
Merged
Conversation
Prevents the failure mode where a misunderstood user signal (mentioning an existing resource) propagates through all 5 pipeline stages and surfaces only at merge. - 01-brainstorm/premise-challenge.md: add rule 5 — when the user references an external resource, reverse-verify intent (incorporate vs already-handled) before scoping. Failure mode documented. - 04-review: Spec axis now traces back to the user's original wording (brainstorm scope), not just plan-vs-diff. Catches directional misunderstandings the plan itself encoded. - tests: +1 contract test (premise-challenge external-resource check) 204 pass, 0 fail. SKILL.md line counts unchanged (rules in references/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
PR #10 的 skill-write 误纳入暴露了一个失败模式：用户提到外部资源时，brainstorm 误判为"纳入"而非"已解决"，误解一路传播到 merge 才暴露。三个 gate（plan/work/review）都假设上游正确，缺回溯。
改动
1. brainstorm 外部资源信号核实（
01-brainstorm/references/premise-challenge.md）2. review Spec 轴加需求回溯（
04-review）验证
```
204 pass / 0 fail / 805 expect() calls
```
SKILL.md 行数未增（01-brainstorm 仍 98，规则落 references/）。