chore: build ordinary CI against llama.cpp v0.5.0 - #129
Merged
Merged
Conversation
Move the ordinary CI/development pin from v0.2.0 to v0.5.0 so the pinned lane builds the bridge and runs its browser smokes against llama.cpp v0.5.0 before llamadart-native publishes its v0.5.0 release. Release candidates keep taking the upstream tag from the native release, so this does not change what any published asset is built from. The exact v0.4.0 compatibility lane is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the ordinary CI/development pin in
llama_cpp.versionfromv0.2.0tov0.5.0, and update the one test that asserts its value (release_contract_test.py).The pinned CI lane then builds the bridge and runs its smokes against llama.cpp
v0.5.0. That happens before llamadart-native publishes itsv0.5.0release (still blocked on leehack/llamadart-native#92 and leehack/llamadart-native#93). Once native publishes, the orchestrator builds a publishable candidate from native's upstream tag. If the bridge breaks on v0.5.0, it's better to find out here: a failed candidate is never retried automatically.What does not change
upstream_tagfrom the native release;bridge_candidate.ymlnever readsllama_cpp.version. Published assets are unaffected.v0.4.0compatibility lane stays as it is.After merge
llama_cpp.versionis a governed path, so the next orchestrator scan dispatches one new candidate for nativev0.4.1-1, probably claimingv0.1.50. It builds from native'sv0.4.1, so its bytes should matchv0.1.49. In that case the pipeline ends assatisfied_by_identical_release, with no qualification or publication, and the tag is freed.Review notes (independent review, nothing blocking)
verify_ci_reliability.pyonly checks the tag's format.CMakeLists.txtstill holds in v0.5.0: themtmd-audio.cppthread marker, the mtmd sources,vendor::hash, andtools/mtmd/CMakeLists.txt, which is unchanged since v0.4.0.mtmd_helper_init_opt_defaultexists in v0.5.0, so the pinned lane now builds the options path. The legacy no-options fallback is still covered bymtmd_compat_contract_test.pyagainst stubs.-Xclang -fno-pch-timestampflag for Clang-ID compilers works with emcc.Local verification
npm run check:jspython3 scripts/verify_ci_reliability.py </dev/nullpython3 -m unittest discover -s scripts -p '*_test.py' </dev/null: 416 tests, OKThe real v0.5.0 build and the browser smokes are this PR's CI. I couldn't run them locally because the local emcc is 6.0.10-git and the pin is 6.0.8.