Skip to content

fix(ui): 收紧会话身份边界——验签后必须匹配当前 USERNAME - #11

Merged
leeefun merged 2 commits into
masterfrom
hardening/ui-session-username-binding
Oct 7, 2026
Merged

leeefun merged 2 commits into
masterfrom
hardening/ui-session-username-binding

Conversation

@leeefun

@leeefun leeefun commented Oct 6, 2026

Copy link
Copy Markdown
Owner

问题

readSession() 验签并解析载荷后,只检查 payload.u 是不是字符串,没有比对当前 env.USERNAME。

签名只证明"这份载荷由当前 PASSWORD 派生的密钥签发过",不证明 u 就是当前用户名。于是改用户名后旧 Cookie 仍然有效——而改密码已经会让旧会话整体失效(密钥按口令值派生),两者本应是同一性质。

改动

  • src/ui/session.ts:验签 + TTL 通过后追加 payload.u !== env.USERNAME → null;顶部几十行历史方案比较压缩成当前事实(HKDF/HMAC、24h exp、改用户名/密码皆失效)。
  • test/hardening.test.ts:新增 G8 三组判据——用户名不变时旧 token 有效;只改 USERNAME 后旧 token 立即失效;新用户名签发的 token 有效。

不新增 sessionVersion、不建 D1 会话表、不加 revoke 表。

验证

  • tsc --noEmit 0 错;eslint 0 告警。
  • 判别力实测:把 env.USERNAME 比对去掉,G8 用例转红。
  • test/hardening.test.ts、test/ui-guard.test.ts、test/fixes.test.ts 通过。

readSession 此前只检查载荷 u 是字符串,没有比对 env.USERNAME:签名只证明
"这份载荷由当前 PASSWORD 派生的密钥签发过",不证明 u 就是当前用户名。
于是改用户名后旧 Cookie 仍然有效(改密码已经会失效,两者应是同一性质)。

- src/ui/session.ts:验签+TTL 通过后追加 payload.u !== env.USERNAME 即拒;
  顶部几十行历史方案比较压成当前事实(HKDF/HMAC、24h exp、改用户名/密码失效)。
- test/hardening.test.ts:新增 G8(用户名不变有效 / 仅改 USERNAME 旧令牌失效 /
  新用户名签发的令牌有效),并在文件头登记 G8。
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T14:59:15.697327Z f3dd80e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@leeefun
leeefun merged commit 80c50ec into master Oct 7, 2026
1 check passed
@leeefun
leeefun deleted the hardening/ui-session-username-binding branch October 7, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant