-
Notifications
You must be signed in to change notification settings - Fork 0
Add ImplicitMSTestUsings property and ImplicitUsings to test asset projects #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The addition of this namespace to Implicit Usings is causing us problems because we make use of the System.ComponentModel.DescriptionAttribute in more places. * Add ImplicitMSTestUsings property to control MSTest implicit usings * Add comprehensive tests for ImplicitMSTestUsings property
Co-authored-by: MatthewSteeples <255971+MatthewSteeples@users.noreply.github.com>
Co-authored-by: MatthewSteeples <255971+MatthewSteeples@users.noreply.github.com>
Co-authored-by: MatthewSteeples <255971+MatthewSteeples@users.noreply.github.com>
Co-authored-by: MatthewSteeples <255971+MatthewSteeples@users.noreply.github.com>
|
@copilot Can you rebase this branch? |
I'm unable to rebase this branch as I don't have the capability to perform git rebase operations (force push is not available in my environment). The branch needs to be rebased onto the latest main branch which is 4831 commits ahead. Could you perform the rebase yourself, or would you like me to recreate the changes on top of the current main branch instead? |
|
@copilot recreate the changes please |
Changes recreated successfully on top of the latest main branch in commit 3bacd356d. The following changes were applied:
All changes are now based on the current main branch (commit 1b35aad). Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR introduces the
ImplicitMSTestUsingsproperty to control MSTest implicit usings and addsImplicitUsingsconfiguration to all test asset projects for consistency.Problem
Following issue #3 which introduced the
ImplicitMSTestUsingsproperty, many test asset projects intest/IntegrationTests/TestAssets/were missing theImplicitUsingsconfiguration. This created inconsistency across the test suite where:Directory.Build.propshas<ImplicitUsings>enable</ImplicitUsings>globallyImplicitUsingsconfigurationSolution
This PR includes two main components:
ImplicitMSTestUsings Property Support: Modified target files to add support for the
ImplicitMSTestUsingsproperty, allowing users to control whether MSTest namespaces are implicitly included whenImplicitUsingsis enabled. The property defaults to enabled when not specified.Test Asset Configuration: Added
<ImplicitUsings>enable</ImplicitUsings>to all 28 test asset projects that were missing this configuration.Changes Made
ImplicitMSTestUsingsproperty support:src/Package/MSTest.Sdk/Sdk/VSTest/VSTest.targetssrc/TestFramework/TestFramework.Extensions/buildTransitive/net8.0AndLater/MSTest.TestFramework.targetssrc/TestFramework/TestFramework.Extensions/buildTransitive/others/MSTest.TestFramework.targetsSdkTests.csto verify theImplicitMSTestUsingsfunctionality with different settings<ImplicitUsings>enable</ImplicitUsings>) to 28 test asset project filesThe changes ensure:
<ImplicitMSTestUsings>false</ImplicitMSTestUsings>or<ImplicitMSTestUsings>disable</ImplicitMSTestUsings>Fixes #4.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.