Enable USE_LATEX=ON by default#28
Merged
allnes merged 1 commit intolearning-process:masterfrom May 31, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to enable USE_LATEX=ON by default by removing the explicit flag from build commands so that the default behavior is applied.
- The README.md has been updated to remove the explicit -D USE_LATEX=ON flag from the build instructions.
- The GitHub Actions workflows have been updated to remove the flag from the cmake build commands, aligning the CI configuration with the intended default behavior.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Removed the -D USE_LATEX=ON flag from the build command and instructions. |
| .github/workflows/main.yml | Removed the -D USE_LATEX=ON flag from each cmake build command in CI jobs. |
Files not reviewed (1)
- CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/main.yml:27
- Removing the -D USE_LATEX=ON flag from the CI build commands conflicts with the PR title. Verify that the default behavior truly enables LaTeX and update the CI documentation or commands accordingly.
cmake -G Ninja -S . -B build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.