Minor changes in "bits_to_vectors"#17
Open
valdaarhun wants to merge 1 commit into
Open
Conversation
Correct dimension of result of Kronecker product. Fix typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. Thank you for the awesome series. There was one thing that I am a little confused about in the 3rd chapter of the 1st part (Linear Algebra for Reversible Circuits).
Since each element of the first vector is being multiplied to all elements of the second vector, I think the dimension of the resultant vector should be the product ($\dim_X * \dim_Y$ ). Am I missing something here?