Skip to content

Hero spacing, responsive fixes, visible grain/scanlines, devtools easter egg - #128

Merged
pemaghising merged 13 commits into
masterfrom
hero-top-spacing
Sep 24, 2026
Merged

pemaghising merged 13 commits into
masterfrom
hero-top-spacing

Conversation

@pemaghising

@pemaghising pemaghising commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Brings the live site in line with what renders locally.

Fixes that only show up in production

Grain and scanline overlays were invisible on the live site. cssnano rewrites the two-position gradient stop 0 1px to 1px. In a repeating-linear-gradient the tile runs from the first stop to the last, so the 1px line became zero-width: both overlays shipped and painted nothing, while looking fine on the unminified dev server. Switched to a plain linear-gradient tiled with background-size — the same pattern .blueprint-grid already uses. Verified by rendering the production build and reading pixels: live is flat, this build shows the 3px texture.

Devtools easter egg never reached production. It lived in an HTML comment, and CRA's html-minifier runs with removeComments. It's now a console.log in an inline script, which prints on load and stays readable in view-source. Verified present in build/index.html.

Responsive fixes

  • Nav: hamburger breakpoint 1100 → 1280px. The old cutoff was sized for four links; with five plus the CTA, Register Now hung past the right edge until ~1250px. Open menu gets a full carbon border, cast shadow, and no doubled divider.
  • Reason cards: titles sized off the card with container queries instead of vw, which fit at 16:9 but wrapped at 16:10 since the column is 1.1fr. Cards stay three-across at 16:10 too: the row only stacks below 600px of column width (~1390px viewport), with side padding easing 32→24px as cards narrow. Titles enlarged ~10% and still hold one line at 1440, 1680 and 1920. Dividers moved to a 2px grid gap so they stay correct when the grid wraps.
  • Recognition art: below 1280px the mecha can't exceed its frame width; at 1214px the 134% height sheared ~110px off each arm. Above 1280px unchanged.

Other

  • Hero copy column dropped further below the nav.
  • "Grow as a Builder" copy updated.
  • Removed unused hero-pilot-tall.png / .webp (nothing imported them).

Testing

  • yarn build passes; production CSS checked for every modern feature used (@container, container-type, aspect-ratio, color-mix, clip-path, text-wrap) — all survive minification.
  • Checked at 1920, 1680, 1560, 1440, 1214, 1130 and narrower widths.

padding-top on .hero-inner goes from clamp(48px, 4.5vw, 80px) to
clamp(72px, 6vw, 112px) -- roughly 65px to 86px at 1440, 80px to 112px
on wide screens.

Only the copy column moves. .hero-art is absolutely positioned against
.hero, so the mech holds its place and the logo, lede, CTA and key-dates
plate drop against it. The 1100px block keeps its own padding-top, so
mobile is unchanged.
'A Month of Code' fit one line at wide viewports while the neighbouring
card wrapped, leaving the row visually unbalanced.
At the shared --card-title size 'Grow as a Builder' wrapped while its
neighbours held one line, leaving the 3-up row ragged. .badge keeps the
shared size.
Titles all hold one line now, so min-height:2em was only opening a gap
above the copy. Balance the body text instead of protecting its last
line, and give the cards more padding.
Nav: the hamburger cutoff was measured against four links and the bar
carries five, so the CTA hung past the right edge until ~1250. Raised to
1280. The open panel gets a full carbon box, a cast shadow and no
duplicate divider under its top border.

Reason cards: the title was sized in vw but the card's width comes from a
1.1fr column, so it fit at 16:9 and wrapped at 16:10. Sized off the
container instead, with the row stacking below 745px of column width.
Dividers move from border-left to a 2px gap so they survive that switch.

Recognition: the art may no longer exceed its frame's width below 1280 --
at 1214 the 134% height made it ~110px wider than the frame on each side
and the clip sheared both arms off.
The art lived in an HTML comment, and CRA's build runs html-minifier with
removeComments, so it was stripped from every deploy -- it only ever
showed in the repo and on the dev server. An inert text/plain script
keeps its raw contents through minification and, unlike a comment before
the doctype, shows up in the Elements panel as well as view-source.

Verified against a production build: build/index.html carries the art
with its alignment intact.
The text/plain block shows in view-source and the Elements tree, but
devtools folds any multi-line text node, so it needs a click. A console
banner needs none -- and the copy already talks about snooping around in
the devtools.

Both survive minification: a production build carries two copies.
The console script's template literal is already plain text in the
source, so view-source showed the art twice. The only thing the extra
block added was an Elements node, which devtools folds anyway.
Nothing imports hero-pilot-tall.png or .webp; HeroArt uses the v2 file.
479 KB of dead weight in the repo.
cssnano rewrites the two-position stop "0 1px" to "1px". Harmless in a
plain gradient, but a repeating gradient tiles from its first stop to its
last, so the 1px line became zero-width and both overlays painted nothing
in production while looking fine on the unminified dev server.

A plain linear-gradient tiled with background-size gives the same 3px
pitch and survives the minifier, the same way .blueprint-grid already
does.
@aws-amplify-ap-south-1

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-128.d1r8cuv7fofw0h.amplifyapp.com

The row stacked below 745px of column width, which a 1680-wide screen
misses by 10px. Cards fit down to 600px once side padding eases from
32px to 24px, so the threshold moves there -- three-across now holds
down to about 1390px of viewport.

Titles were pinned to their 0.95rem floor at every width: cqi measures
the card's content box, which excludes the padding. Floor to 1.05rem and
8.5cqi to 1.6rem makes them grow ~10% and still hold one line.
@pemaghising pemaghising reopened this Sep 23, 2026
@pemaghising
pemaghising merged commit 845dec5 into master Sep 24, 2026
2 checks passed
@pemaghising
pemaghising deleted the hero-top-spacing branch November 5, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants