Skip to content

Recognition and nav updates, favicon cleanup, and a CSS authority fix - #127

Merged
pemaghising merged 3 commits into
masterfrom
recognition-nav-updates
Sep 18, 2026
Merged

pemaghising merged 3 commits into
masterfrom
recognition-nav-updates

Conversation

@pemaghising

Copy link
Copy Markdown
Collaborator

Six commits covering the Recognition section and nav work, favicon cleanup, FAQ/button motion, and a final pass that resolves a CSS authority problem introduced partway through the branch.

The part worth reviewing carefully

src/type-reference.css was added on this branch as a type-scale comparison overlay. Its own header described it as deletable, but it shipped: index.js imported it and index.html carried data-typeref="on".

Every rule in it was scoped [data-typeref='on'] .class. That outranks the plain class selectors in index.css, so index.css read as the source of truth while the overlay was what actually rendered. Edits to index.css for any overridden property silently did nothing.

The last commit merges all 24 overrides into index.css and deletes the overlay. No visual change — the site already rendered those values. --content-max moves to 1600px so the measure cap lives in the token instead of being contradicted by a shadow rule.

Review note: the diff shows type-reference.css added and then deleted across two commits on this branch. That's noise, but squashing it would mean rebasing commits already pushed to the shared remote, so it's been left readable instead.

Accessibility

  • Collapsed mobile menu kept its five links in the tab order. max-height, opacity and pointer-events hide a menu visually, but none of them remove it from the a11y tree — keyboard users tabbed into an invisible menu. Adds visibility, delayed so it lands after the collapse rather than cutting it. (WCAG 2.4.3 / 2.4.7)
  • One dual-ring :focus-visible replacing three inconsistent rules. No single palette colour clears 3:1 on both surfaces — cyan is 4.59:1 on --surface but 1.27:1 on --paper, and carbon is the reverse — so a carbon band sits inside a cyan one and whichever disappears into the background, the other still reads. (WCAG 1.4.11)

Layout and type

  • .wrap now sizes with width rather than max-width + padding. Three things had been leaning on the old mechanism and broke: .hero-inner's width: 100% outranked it on source order, .footer .wrap's horizontal padding stacked on the gutter instead of replacing it, and a position: static mobile override sat above the rule it was meant to override. All three fixed; the file was swept for further instances.
  • Breakpoints consolidated from 8 ad-hoc values to 5 documented tiers.
  • Recognition card titles reduced — the ratio to body copy was 1.74, too hard a step for a stacked list row.
  • Title-to-copy gap 8px → 12px, since line-height: 1 strips the leading that normally does half that work.
  • Timeline rows centre rather than baseline-align against a multi-line copy column.
  • Beyond mech is no longer cropped: the picture box computed to 1.425 against the artwork's 1.4471, so object-fit: cover trimmed the forearms. Height now derives from aspect-ratio: 2696/1863.
  • IBM Plex Mono now loads 600 and 700. The overlay set font-weight: 700 on .tag without those weights present, so every eyebrow label on the site was a browser-synthesized fake bold.
  • All rgba() literals moved to color-mix() on tokens; remaining 13.5px body copy brought onto the scale.

Tooling

.npmrc sets --openssl-legacy-provider. react-scripts 3.x builds on webpack 4, whose module hashing calls an OpenSSL digest Node 17+ removed — npm start and npm run build fail outright with ERR_OSSL_EVP_UNSUPPORTED. npm applies node-options to the scripts it runs, so this fixes every platform with no cross-env dependency. engines raised to >=18 because the flag postdates Node 16, which is long EOL.

Verification

  • npm run prettier passes
  • Build compiles clean
  • Design detector: one finding, the nav's max-height transition — a once-per-tap animation whose grid-template-rows fix needs an extra wrapper element, so left as is

npm run eslint reports ~1000 linebreak-style errors, all pre-existing across the whole repo — core.autocrlf=true checks files out as CRLF while the rule demands LF. No real code errors. Fixing it needs a .gitattributes or a rule change, so it's left for a separate PR.

Not addressed

GitHub reports 170 vulnerabilities on the default branch (21 critical, 78 high), all from the aged react-scripts 3.x / webpack 4 stack — the same age that requires the OpenSSL flag above. Upgrading is its own piece of work.

type-reference.css was a temporary comparison overlay, self-described as
deletable, but it shipped: index.js imported it and index.html carried
data-typeref="on". Every rule was `[data-typeref=on] .class`, outranking
the plain classes in index.css, so index.css read as the authority while
the overlay actually rendered. Edits to index.css silently did nothing.

Merge all 24 overrides into index.css and delete the overlay. No visual
change; the site already rendered these values. --content-max moves to
1600px so the measure cap lives in the token rather than being
contradicted by a shadow rule.

Accessibility:
- Collapsed mobile menu kept its five links in the tab order. max-height,
  opacity and pointer-events hide it visually but none remove it from the
  a11y tree; add visibility, delayed so it lands after the collapse.
- Single dual-ring :focus-visible replacing three inconsistent rules. No
  palette colour clears 3:1 on both surfaces (cyan 4.59:1 on --surface but
  1.27:1 on --paper; carbon the reverse), so a carbon band sits inside a
  cyan one and whichever vanishes, the other reads.

Layout and type:
- .wrap sizes with width, not max-width + padding. Removed the width from
  .hero-inner and the horizontal padding from .footer .wrap, both of which
  had been relying on the old mechanism and stacked or overrode the gutter.
- Breakpoints consolidated 8 tiers to 5 and documented.
- Recognition card titles down to clamp(1.25rem, 1.9vw, 1.8rem); ratio to
  body copy was 1.74, too hard a step for a stacked list row.
- Title-to-copy gap 8px to 12px: line-height 1 strips the leading that
  would normally do half that work.
- Timeline rows centre rather than baseline-align, so the date and phase
  sit against the middle of a multi-line copy column.
- Beyond mech no longer cropped: the picture box computed to 1.425 against
  the artwork's 1.4471, and object-fit: cover trimmed the forearms. Derive
  height from aspect-ratio 2696/1863 instead.
- IBM Plex Mono now loads 600 and 700. The overlay set font-weight 700 on
  .tag without them, so every eyebrow label was a synthesized fake bold.
- All rgba() literals to color-mix() on tokens; .demoday .lede off the
  borders-only token; remaining 13.5px body copy onto the scale.

Tooling:
- .npmrc sets --openssl-legacy-provider. react-scripts 3.x on webpack 4
  dies on Node 17+ with ERR_OSSL_EVP_UNSUPPORTED, so npm start failed for
  everyone. engines raised to >=18 because the flag postdates Node 16,
  which is long EOL.
The previous commit raised engines to >=18 and added .npmrc setting
--openssl-legacy-provider. Both were wrong for this repo:

- .github/workflows/build.yml pins node-version: 16, so yarn's engine
  validation refused to install: "The engine node is incompatible with
  this module. Expected >=18.0.0. Got 16.20.2".
- CI runs yarn, not npm. node-options in .npmrc is an npm script-runner
  config, so it would not have reached the team's builds anyway.

The OpenSSL digest failure only affects Node 17+, which is why CI was
green throughout. It is a local-development problem, not a CI one, and
fixing it properly means moving CI to a supported Node first -- a call
for the team, not a side effect of a design PR.

Until then, local dev on Node 17+ needs:
  NODE_OPTIONS=--openssl-legacy-provider yarn start
@aws-amplify-ap-south-1

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-127.d1r8cuv7fofw0h.amplifyapp.com

Recognition writes its section head without the .sec-head wrapper every
other section uses, so `.sec-head .h2` never matched it and its heading
sat tight against the tag while Beyond, Timeline, Resources and
Guidelines all had the 13px gap.

`.tag + .h2` states the actual relationship -- a heading that follows an
eyebrow -- so it holds regardless of wrapper. Only Recognition changes;
DemoDay carries the .h1 class and is unaffected.
@pemaghising
pemaghising merged commit a829c27 into master Sep 18, 2026
3 checks passed
@pemaghising
pemaghising deleted the recognition-nav-updates branch November 5, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants