Skip to content

test(e2e): find the deferred input pane before its cancel button is visible - #538

Merged
harryisfish merged 2 commits into
mainfrom
fix/ios-deferred-cancel
Nov 10, 2026
Merged

harryisfish merged 2 commits into
mainfrom
fix/ios-deferred-cancel

Conversation

@harryisfish

@harryisfish harryisfish commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

问题

#528 合并后,iOS Provider 验收已能越过以往失败点,但每次(3/3)都在 native-transfers.e2e.ts:540 失败:expect(deferredScroll).toHaveCount(1) 找不到包含“取消稍后输入”的滚动区。

原因是筛选滚动区的 has 用了从面板开始、且要求可见的按钮定位器。has 在每个滚动区内部查找,等于要求滚动区里再有一个面板,所以永远匹配不到,测试根本走不到点击。

修改

  • 滚动区改用从屏幕根开始、不要求可见的按钮定位器筛选,与 workspace.native.ts 的同类写法一致。
  • 点击前等按钮位置稳定并完整落在滚动区内,同样沿用 workspace.native.ts 的做法。

只改测试,不改产品代码。

验证

  • tsc -p tests/e2e/tsconfig.e2e.json 通过。
  • 在本分支手动触发 mobile.yml(只跑 iOS),整套 iOS Provider 验收通过,无失败项。
  • 中间一次在第 321 行读剪贴板偶发失败,重跑通过,与本改动无关。

负责人:harryisfish。状态:处理中。

…isible

The iOS provider run failed every time before cancelling the deferred
input: the scroll pane was looked up by the cancel button with
visible: true, which matches nothing while the button is still below the
fold. Match the pane by the button regardless of visibility and wait for
its bounds to settle inside the pane before clicking, as the workspace
native test already does.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这次不合并。改动只有测试定位,方向是对的,但描述写明 iOS workflow 还在跑,状态仍是处理中。没有当前 head 的通过记录之前保持 Draft。

View PR

Open in Web View Automation 

Sent by Cursor Automation: Vibeface 清理

@harryisfish
harryisfish marked this pull request as ready for review November 10, 2026 14:44
@harryisfish
harryisfish merged commit 653ea8d into main Nov 10, 2026
2 checks passed
@harryisfish
harryisfish deleted the fix/ios-deferred-cancel branch November 10, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant