Skip to content

ci: redesign Nightly so it needs no PAT (version on the tag only) #533

Closed

Description

@harryisfish

Problem

The scheduled daily-nightly job has never completed a Nightly since it was enabled by default (#525). The repository has no NIGHTLY_RELEASE_TOKEN secret, so every scheduled ci run fails at the first step of daily-nightly. Nightly 20261110.2 was published by hand (#529).

The token exists only because the flow merges a version-bump PR into main: a merge or push made with GITHUB_TOKEN does not trigger workflows, and the main ruleset requires a PR.

Proposal

Put the version only on the tag, so the Nightly flow no longer needs a PAT:

  • On a main SHA whose scheduled CI passed, create a commit that changes only the version files. Tag that commit without merging it into main, then dispatch release.yml using GITHUB_TOKEN.
  • release.py: relax --require-main to require that the tag's parent is on main and that the diff touches only version files. Reuse expected_tree/verify_tree from daily-nightly.py.
  • Skip the run when main has no new commits since the previous Nightly tag.
  • Derive the mobile build number from the tags (max of main and the latest Nightly tag, plus one).
  • Delete the PR, merge, PAT, and wait-for-CI logic from daily-nightly.py, plus the token check in ci.yml. Update packages/docs/ci.md, packages/docs/releasing.md, and the release skill.
  • Remove the unused VIBEFACE_RELEASE_DISPATCH_TOKEN secret, which nothing references.

Open decision: cadence (daily, or keep every four hours).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions