Skip to content

feat(Algebra/Group/Submonoid/Defs): add OneMemClass.coe_nonempty#38288

Open
b-mehta wants to merge 1 commit intoleanprover-community:masterfrom
b-mehta:feat/submonoid-coe-nonempty
Open

feat(Algebra/Group/Submonoid/Defs): add OneMemClass.coe_nonempty#38288
b-mehta wants to merge 1 commit intoleanprover-community:masterfrom
b-mehta:feat/submonoid-coe-nonempty

Conversation

@b-mehta
Copy link
Copy Markdown
Contributor

@b-mehta b-mehta commented Apr 20, 2026

The main value of this is to make simp stronger


Open in Gitpod

@b-mehta b-mehta added the easy < 20s of review time. See the lifecycle page for guidelines. label Apr 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 20, 2026

PR summary 4fceb4697e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ OneMemClass.coe_nonempty

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 20, 2026
@plp127
Copy link
Copy Markdown
Contributor

plp127 commented Apr 20, 2026

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 20, 2026

Benchmark results for 6a8a721 against 4fceb46 are in. There are significant results. @plp127

  • 🟥 main exited with code 1

No significant changes detected.

Copy link
Copy Markdown
Contributor

@plp127 plp127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix the simpNF and unused arguments

@b-mehta b-mehta force-pushed the feat/submonoid-coe-nonempty branch from 6a8a721 to 40b984f Compare April 20, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants