feat(Logic/Equiv/Defs): add coe_ofBijective simp lemma#38286
feat(Logic/Equiv/Defs): add coe_ofBijective simp lemma#38286b-mehta wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 4fceb4697eImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
| left_inv := leftInverse_surjInv hf | ||
| right_inv := rightInverse_surjInv _ | ||
|
|
||
| @[simp] lemma coe_ofBijective (f : α → β) (hf : Bijective f) : ⇑(ofBijective f hf) = f := rfl |
There was a problem hiding this comment.
Doesn't having this prevent Equiv.apply_symm_apply firing on ofBijective f hf ((ofBijective f hf).symm x)? I think we often avoid making such lemmas simp for this reason.
| @[simp] lemma coe_ofBijective (f : α → β) (hf : Bijective f) : ⇑(ofBijective f hf) = f := rfl | |
| lemma coe_ofBijective (f : α → β) (hf : Bijective f) : ⇑(ofBijective f hf) = f := rfl |
There was a problem hiding this comment.
Doesn't ofBijective_apply already do that?
There was a problem hiding this comment.
Exactly, and there are already loads of @[simp] lemmas like this in mathlib, eg QuaternionAlgebra.coe_addEquivTuple, Equiv.coe_constVSub, WithZero.coe_expEquiv_apply (which I found by just looking through search results in alphabetic order.
We have the applied version of this, but that doesn't fire on the coerced equiv