Skip to content

chore(Algebra/Lie/Submodule): remove duplicate instance#38282

Open
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-LieSubmodule-CoeSort
Open

chore(Algebra/Lie/Submodule): remove duplicate instance#38282
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-LieSubmodule-CoeSort

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb commented Apr 20, 2026

This PR removes the explicit CoeSort instance on LieSubmodule, because it is identical to the one inherited from its SetLike instance.

This instance was added in #16509, and I'm not quite sure why it was needed then and not anymore.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 0e6b5bebd4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- instance (priority := high) coeSort : CoeSort (LieSubmodule R L M) (Type w)

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 20, 2026
@JovanGerb JovanGerb requested a review from mattrobball April 20, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant