Skip to content

chore(CategoryTheory): fix diamond for the preadditive structure on the opposite category#38281

Open
joelriou wants to merge 4 commits intoleanprover-community:masterfrom
joelriou:preadditive-op-fix
Open

chore(CategoryTheory): fix diamond for the preadditive structure on the opposite category#38281
joelriou wants to merge 4 commits intoleanprover-community:masterfrom
joelriou:preadditive-op-fix

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Apr 20, 2026

@joelriou joelriou added the t-category-theory Category theory label Apr 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 20, 2026

PR summary 71f5543cfd

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
6532 -2 backward.isDefEq.respectTransparency

Current commit 7a62c773c0
Reference commit 71f5543cfd

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@riccardobrasca
Copy link
Copy Markdown
Member

Can you add the rfl proof that now works as an example?

Comment thread Mathlib/CategoryTheory/Preadditive/Opposite.lean Outdated
@joelriou
Copy link
Copy Markdown
Contributor Author

Can you add the rfl proof that now works as an example?

Thanks for the suggestion! I have just added it.

@joelriou
Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 20, 2026

Benchmark results for 7a62c77 against 71f5543 are in. No significant results found. @joelriou

  • 🟥 build//instructions: +14.3G (+0.01%)

Small changes (2✅, 1🟥)

  • build/module/Mathlib.Tactic.CasesM//instructions: -130.1M (-2.24%)
  • build/module/Mathlib.Tactic.Linarith.Preprocessing//instructions: -717.0M (-4.58%)
  • 🟥 build/module/Mathlib.Tactic.MinImports//instructions: +139.4M (+2.77%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants