Skip to content

refactor(NumberTheory): golf Mathlib/NumberTheory/NumberField/Basic #38279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuanyi-350 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −6
Open

refactor(NumberTheory): golf Mathlib/NumberTheory/NumberField/Basic #38279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Mathlib/NumberTheory/NumberField/Basic.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,12 +179,8 @@ lemma mk_eq_mk (x y : K) (hx hy) : (⟨x, hx⟩ : 𝓞 K) = ⟨y, hy⟩ ↔ x =

/-- The ring homomorphism `(𝓞 K) →+* (𝓞 L)` given by restricting a ring homomorphism
`f : K →+* L` to `𝓞 K`. -/
def mapRingHom {K L : Type*} [Field K] [Field L] (f : K →+* L) : (𝓞 K) →+* (𝓞 L) where
toFun k := ⟨f k.val, map_isIntegral_int f k.2⟩
map_zero' := by ext; simp only [map_mk, map_zero]
map_one' := by ext; simp only [map_mk, map_one]
map_add' x y := by ext; simp only [map_mk, map_add]
map_mul' x y := by ext; simp only [map_mk, map_mul]
def mapRingHom {K L : Type*} [Field K] [Field L] (f : K →+* L) : (𝓞 K) →+* (𝓞 L) :=
f.toIntAlgHom.mapIntegralClosure.toRingHom

@[simp]
theorem mapRingHom_apply {K L : Type*} [Field K] [Field L] (f : K →+* L) (x : 𝓞 K) :
Expand Down
Loading