refactor(Analysis): golf Mathlib/Analysis/Complex/Trigonometric#38274
Open
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Open
refactor(Analysis): golf Mathlib/Analysis/Complex/Trigonometric#38274yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Mathlib/Analysis/Complex/Trigonometric#38274yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary c3e588b468Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Collaborator
Author
|
I ran a profiler comparison for the changed declarations in this PR. Results (seconds):
Overall:
|
19 tasks
| rw [h2, cos_sq'] | ||
| ring | ||
| rw [← two_add_one_eq_three, add_one_mul, sin_add (2 * x) x] | ||
| grind [cos_two_mul, sin_two_mul, cos_sq'] |
Collaborator
There was a problem hiding this comment.
Since the performance is worse, maybe do this instead:
Suggested change
| grind [cos_two_mul, sin_two_mul, cos_sq'] | |
| simp only [cos_two_mul, sin_two_mul, cos_sq', mul_assoc, ← sq] | |
| ring |
same proof as before, but without the haves. Should probably have the same performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cos_three_mulviacosh_three_muland thecosh_mul_Iconversionsin_three_mulusingsin_add, double-angle identities, andgrindExtracted from #37968