Skip to content

feat(Combinatorics/Additive): link Freiman homs and Freiman isos tighter#38269

Draft
b-mehta wants to merge 14 commits intoleanprover-community:masterfrom
b-mehta:bm-wip-merged
Draft

feat(Combinatorics/Additive): link Freiman homs and Freiman isos tighter#38269
b-mehta wants to merge 14 commits intoleanprover-community:masterfrom
b-mehta:bm-wip-merged

Conversation

@b-mehta
Copy link
Copy Markdown
Contributor

@b-mehta b-mehta commented Apr 20, 2026

Some work I had lying around in a forgotten branch, recently resurrected.


Open in Gitpod

b-mehta and others added 14 commits September 6, 2024 14:45
Conflict resolutions:
- Algebra/BigOperators/Group/Multiset.lean: accept master's deletion (split into Multiset/Basic + Defs)
- FreimanHom.lean: keep bm-wip's new lemmas (IsMulFreimanIso.symm, toIsMulFreimanIso,
  isMulFreimanIso_invFunOn, prod_apply, isMulFreimanHom_antitone, prodMk, fst, snd,
  refactored mono/prodMap/IsMulFreimanIso.mono); take master's renamed tactics (simp_all,
  notMem); update map_multiset_prod_ne_zero → map_multiset_ne_zero_prod; update subtypeVal
  to use MulHomClass.isMulFreimanHom
- Behrend.lean, Defs.lean: take master's updated structure, keep AddHomClass weakening
@github-actions
Copy link
Copy Markdown

PR summary 9519868b83

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ InjOn.left_prodMk
+ InjOn.right_prodMk
+ IsMulFreimanHom.fst
+ IsMulFreimanHom.prodMk
+ IsMulFreimanHom.prod_apply
+ IsMulFreimanHom.snd
+ IsMulFreimanHom.toIsMulFreimanIso
+ IsMulFreimanIso.isMulFreimanIso_invFunOn
+ IsMulFreimanIso.symm
+ LeftInvOn.left_prodMk
+ LeftInvOn.right_prodMk
+ MapsTo.prodMk
+ MulHomClass.isMulFreimanHom
+ card_eq_succ
+ isMulFreimanHom_antitone
+ length_eq_succ_iff
+ surjOn_fst
+ surjOn_fst_iff
+ surjOn_snd
+ surjOn_snd_iff
- MonoidHomClass.isMulFreimanHom

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant