You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Set.Iio a (when it's nonempty) inherits the ConditionallyCompleteLinearOrderBot structure from the base type. This is commonly used in set theory, where we consider the ordinals within a, and convert Iio a from/to Ordinal.
There should also be a ConditionallyCompleteLinearOrder instance, but adding this seems difficult for now because the junk value may not be the same as bottom (which has been mentioned as "refactor that will allow different
default values for sSup and sInf" in the module doc). Since my motivation is for the ordinals purely, this PR only adds a single ConditionallyCompleteLinearOrderBot instance.
I'm not very familiar with the API design here, so any suggestion would be helpful.
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>
The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
There should also be a ConditionallyCompleteLinearOrder instance, but adding this seems difficult for now because the junk value may not be the same as bottom.
This is part of the reason why I've been wishing for some base typeclass for suprema/infima which states that they take on the correct values for all sets where a LUB/GLB exists. We've been floating around ideas like these for a few months, see this Zulip thread.
I feel uncomfortable making things such as sInf (∅ : Iio 5) = ∅ into theorems.
I don't think this type checks? If you write it as sInf (∅ : Set (Iio 5)) = (⊥ : Iio 5), this looks fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set.Iio a(when it's nonempty) inherits theConditionallyCompleteLinearOrderBotstructure from the base type. This is commonly used in set theory, where we consider the ordinals withina, and convertIio afrom/toOrdinal.There should also be a
ConditionallyCompleteLinearOrderinstance, but adding this seems difficult for now because the junk value may not be the same as bottom (which has been mentioned as "refactor that will allow differentdefault values for
sSupandsInf" in the module doc). Since my motivation is for the ordinals purely, this PR only adds a singleConditionallyCompleteLinearOrderBotinstance.I'm not very familiar with the API design here, so any suggestion would be helpful.