Skip to content

chore: fix implicit-reducible diamond in languages #38256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgouezel wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −10
Open

chore: fix implicit-reducible diamond in languages #38256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions Mathlib/ModelTheory/LanguageMap.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,19 +449,18 @@ end

open FirstOrder

instance constantsOnSelfStructure : (constantsOn M).Structure M :=
constantsOn.structure id
variable (α : Type*) [(constantsOn α).Structure M]

instance withConstantsSelfStructure : L[[M]].Structure M :=
instance withConstantsStructure : L[[α]].Structure M :=
inferInstanceAs <| (L.sum _).Structure M

instance withConstants_self_expansion : (lhomWithConstants L M).IsExpansionOn M :=
⟨fun _ _ => rfl, fun _ _ => rfl⟩
instance constantsOnSelfStructure : (constantsOn M).Structure M :=
fast_instance% constantsOn.structure id

variable (α : Type*) [(constantsOn α).Structure M]
instance withConstantsSelfStructure : L[[M]].Structure M := inferInstance

instance withConstantsStructure : L[[α]].Structure M :=
inferInstanceAs <| (L.sum _).Structure M
instance withConstants_self_expansion : (lhomWithConstants L M).IsExpansionOn M :=
⟨fun _ _ => rfl, fun _ _ => rfl⟩

instance withConstants_expansion : (L.lhomWithConstants α).IsExpansionOn M :=
⟨fun _ _ => rfl, fun _ _ => rfl⟩
Expand Down Expand Up @@ -510,9 +509,9 @@ def Embedding.withConstants (_f : M ↪[L] N) (_A : Set M) : Type w' := N
deriving L.Structure

instance (f : M ↪[L] N) : (constantsOn A).Structure (f.withConstants A) :=
constantsOn.structure fun a => f a
fast_instance% constantsOn.structure fun a => f a

instance : L[[A]].Structure (f.withConstants A) := L.withConstantsStructure A
instance : L[[A]].Structure (f.withConstants A) := inferInstance

/-- Lifts an embedding to the expanded language with constants. -/
def Embedding.liftWithConstants :
Expand Down
Loading