[Merged by Bors] - refactor: golf only FactorisationProperties#38204
Closed
yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - refactor: golf only FactorisationProperties#38204yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
FactorisationProperties#38204yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary 0e6b5bebd4Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
bot
added
the
t-number-theory
7 tasks
MichaelStollBayreuth
added
the
awaiting-author
Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
yuanyi-350
removed
the
awaiting-author
Contributor
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by MichaelStollBayreuth. |
mathlib-triage
bot
added
the
maintainer-merge
Member
|
Thanks! bors merge |
mathlib-triage
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2026
This PR selectively ports part of #38144 and only migrates the changes in: - `Mathlib/NumberTheory/FactorisationProperties.lean` Concretely, this PR: - rewrites `Prime.not_pseudoperfect` to use `Prime.properDivisors` and `Finset.sum_le_sum_of_subset` directly, instead of analyzing the powerset of proper divisors by cases - shortens `Prime.not_perfect` to the direct consequence of `Prime.not_pseudoperfect` - refactors `Prime.deficient_pow` to reuse `properDivisors_prime_pow` and a simple mapped-sum identity, instead of reproving the structure of the proper divisors of a prime power inline
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
FactorisationPropertiesFactorisationProperties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR selectively ports part of #38144 and only migrates the changes in:
Mathlib/NumberTheory/FactorisationProperties.leanConcretely, this PR:
Prime.not_pseudoperfectto usePrime.properDivisorsandFinset.sum_le_sum_of_subsetdirectly, instead of analyzing the powerset of proper divisors by casesPrime.not_perfectto the direct consequence ofPrime.not_pseudoperfectPrime.deficient_powto reuseproperDivisors_prime_powand a simple mapped-sum identity, instead of reproving the structure of the proper divisors of a prime power inline