refactor: golf only Cyclotomic/Basic, ArithmeticFunction/Zeta#38202
refactor: golf only Cyclotomic/Basic, ArithmeticFunction/Zeta#38202yuanyi-350 wants to merge 7 commits intoleanprover-community:masterfrom
Cyclotomic/Basic, ArithmeticFunction/Zeta#38202Conversation
PR summary 0e6b5bebd4Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
ArithmeticFunction/Defs, ArithmeticFunction/ZetaCyclotomic/Basic, ArithmeticFunction/Zeta
|
Please don't add golfs in unrelated files. It works best when PRs are small and self-contained. |
|
Sorry, I think the golf in the original file seems meaningless, so I plan to clean up the original file and add a new one; otherwise, this PR would be too small. It seems I should propose a new PR. |
|
Why should the golf in Mathlib/NumberTheory/ArithmeticFunction/Zeta.lean be meaningless? More concretely, please reduce this PR to deal with Mathlib/NumberTheory/ArithmeticFunction/Zeta.lean and open a separate PR for Mathlib/NumberTheory/Cyclotomic/Basic.lean. |
This PR selectively ports part of #38144 and only migrates the changes in:
Mathlib/NumberTheory/ArithmeticFunction/Defs.leanMathlib/NumberTheory/ArithmeticFunction/Zeta.leanConcretely, this PR:
one_smul'andmul_oneinArithmeticFunction/Defsby rewriting them through mapped divisor sums andsum_eq_single, instead of the previous manualby_cases/sum_subsetargumentcoe_zeta_mul_comminArithmeticFunction/Zetadirectly from the swappeddivisorsAntidiagonalsum, and then derivescoe_mul_zeta_applyfrom that commutativity lemma