refactor: weaken assumptions in LpSeminorm/Count, ProductMeasure#38115
Closed
yuanyi-350 wants to merge 3 commits intoleanprover-community:masterfrom
Closed
refactor: weaken assumptions in LpSeminorm/Count, ProductMeasure#38115yuanyi-350 wants to merge 3 commits intoleanprover-community:masterfrom
LpSeminorm/Count, ProductMeasure#38115yuanyi-350 wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
PR summary 05475cac70Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
LpSeminorm/Count, Pi, ProductMeasure (selected files only)LpSeminorm/Count, ProductMeasure
2 tasks
Contributor
|
As in the other PRs, can you benchmark this PR and give it a more telling PR description? Thanks! |
Collaborator
Author
|
I ran a profiler comparison for the changed declarations in this PR. Results (seconds):
Overall:
Caveat:
|
Collaborator
Author
|
Although |
grunweg
reviewed
Apr 16, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This selectively ports part of #38104.
Included files only:
Mathlib/MeasureTheory/Function/LpSeminorm/Count.leanMathlib/MeasureTheory/Constructions/Pi.leanMathlib/Probability/ProductMeasure.leanConcretely, it does three things.
Mathlib/MeasureTheory/Constructions/Pi.lean, it rewritespi_map_piCongrLeftso that it is derived directly frommeasurePreserving_piCongrLeft; this removes the old[Fintype ι']assumption and makes the lemma more general.Mathlib/MeasureTheory/Function/LpSeminorm/Count.lean, it replaces a case-split proof ofeLpNorm_count_lt_top_of_ltwith a cleaner argument that bounds the function by a finite constant on a finite type and then applies generaleLpNorm/MemLplemmas; as a result, that theorem no longer needsMeasurableSingletonClass α.Mathlib/Probability/ProductMeasure.lean, it updatespiContent_eq_measure_pito use the generalizedpi_map_piCongrLeft.