Skip to content

feat: Primitive Laws for completeness#474

Open
markusdemedeiros wants to merge 19 commits into
masterfrom
completeness-primitivelaws
Open

feat: Primitive Laws for completeness#474
markusdemedeiros wants to merge 19 commits into
masterfrom
completeness-primitivelaws

Conversation

@markusdemedeiros

@markusdemedeiros markusdemedeiros commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Description

Depends on #473

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@markusdemedeiros markusdemedeiros force-pushed the completeness-primitivelaws branch from 7b02c93 to de423d2 Compare June 23, 2026 23:28
@markusdemedeiros markusdemedeiros marked this pull request as ready for review July 1, 2026 23:35
@markusdemedeiros markusdemedeiros requested a review from Kaptch July 1, 2026 23:35
@markusdemedeiros

Copy link
Copy Markdown
Collaborator Author

Ready for review--I don't fully understand prophecy variables in the HeapLang semantics, so that was just plain translation.

@Kaptch

Kaptch commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Cool! Thank you! I will take a look tomorrow :)
There is a TODO note in ghost maps file. Is it for w or it is a left-over comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants