Skip to content

feat: port boxes#466

Open
Kaptch wants to merge 20 commits into
leanprover-community:masterfrom
Kaptch:boxes
Open

feat: port boxes#466
Kaptch wants to merge 20 commits into
leanprover-community:masterfrom
Kaptch:boxes

Conversation

@Kaptch

@Kaptch Kaptch commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes #294

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@Kaptch Kaptch requested a review from lzy0505 June 25, 2026 12:41
@lzy0505 lzy0505 mentioned this pull request Jun 29, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port base_logic/lib/boxes.v

2 participants