Skip to content

feat: add depends on rocq concept status#329

Open
ayhon wants to merge 5 commits into
leanprover-community:masterfrom
ayhon:fele/feat/add-depends-on-rocq_concept-status
Open

feat: add depends on rocq concept status#329
ayhon wants to merge 5 commits into
leanprover-community:masterfrom
ayhon:fele/feat/add-depends-on-rocq_concept-status

Conversation

@ayhon

@ayhon ayhon commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Description

Adds support for specifying a concept not being implemented because it depends on some other identifiers. Nothing is done with this information yet.

Fixes #327

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have updated PORTING.md as appropriate
  • I have added my name to the authors section of any appropriate files

@MackieLoeffel

Copy link
Copy Markdown
Collaborator

@ayhon Is this still relevant or can this be closed?

@ayhon

ayhon commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

I made this PR as a proof-of-concept to have a new "depends_on" status for rocq_concept. If we're not interested in implementing such a feature, this PR should be closed, but I don't know whether @lzy0505 had a look at it / had any opinions on it. Reference to the related Zulip conversation.

@lzy0505

lzy0505 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Sorry for the late reply. I think in general it is a nice feature.

However, I'm not sure whether the new depends_on status should be part of rocq_concept.
In my experience, I usually wanted to mark a Rocq definition/lemma that we do want to have a one-to-one map in Lean blocked by missing Rocq lemmas. rocq_concept is only for those that do not have such a clear correspondence, and I cannot use your feature to do it. Perhaps you implemented this feature for other things? Can you give some concrete examples? For my use case, we can instead add a new rocq_blocked command with a "depends-on" list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: allow tracking of rocq_concepts which are blocked by other concept's implementation

3 participants