fix: amend string bondary bugs in gitleaks-original-encoded-secrets#1
fix: amend string bondary bugs in gitleaks-original-encoded-secrets#1eliranmal wants to merge 1 commit intoleaktk:mainfrom
Conversation
- fix counting error in column bounding markers: for some reason in gitleaks reports they're off by 1 - omit `keepends=True` when splitting lines; multiline is gonna be supported via counting (see next item) - account for multiple lines in found secrets when calculating column-end marker, by subtracting the column-start marker if the secret spans multiple lines in the original repo
|
@eliranmal thanks for the PR! Hmm it looks like when I have a secret file that looks like this in a repo: I see some errors with the output: Were you potentially running on a Windows machine or working with something with windows newlines in the file? If so, I think I know a fix 👌 (Yeah for some reason gitleaks captures the newline split at the beginning of the line. If that's it, I think I have an idea for a fix ^_^ |
oh no! i was apparently testing on a repo that doesn't seem to have enough test-cases to properly check all scenarios, so i don't have more ideas on how to fix that..
no - i'm running macos (V 15.5).
okay, lemme know if i can offer any help testing/reproducing etc. |
keepends=Truewhen splitting lines; multiline is gonna be supported via counting (see next item)